[MacPorts] #66855: emacs @28.2_1 uses on macOS Monterey a deprecated ld switch: -no_pie

[MacPorts]

#66855: emacs @28.2_1 uses on macOS Monterey a deprecated ld switch: -no_pie
----------------------------+--------------------
 Reporter:  ballapete       |      Owner:  (none)
     Type:  defect          |     Status:  new
 Priority:  Normal          |  Milestone:
Component:  ports           |    Version:  2.8.1
 Keywords:  monterey intel  |       Port:  emacs
----------------------------+--------------------
 When building GNU Emacs 28.2 on macOS Monterey, Version 12.6.3, I get ten
 times this complaint:

 {{{
 ld: warning: -no_pie is deprecated when targeting new OS versions
 }}}

 Can't it be switched off? Where does it come from?

 `Portfile` has a strange construct:

 {{{
  77 platform darwin {
  78     post-patch {
  79         # Leopard's Xcode 3.1.x ld(1) man page claims -no_pie is
 supported, but it's not
  80         if {${os.major} < 9} {
  81             reinplace "s:-fno-pie::" ${worksrcpath}/configure
  82         } elseif {${os.major} > 10} {
  83             configure.ldflags-append -Wl,-no_pie
  84         }
  85         # Without this flag, there are more than 90000 warnings if the
  86         # system's `clang` compiler is used, increasing the log file
  87         # size by a factor of 200, see
  88         # https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56736
  89         if {${os.major} >= 11 || ${os.major} <= 12} {
  90             configure.cflags-append -Wno-attributes
  91         }
  92     }
  93 }
 }}}

 Line #89: in reality os.major can be  >= 11 **AND** <= 12 – exactly then
 when it is 12.

-- 
Ticket URL: <https://trac.macports.org/ticket/66855>
MacPorts <https://www.macports.org/>
Ports system for macOS