[MacPorts] #65710: graphene @1.10.8_0+universal: graphene-1.0.pc differs and cannot be merged
MacPorts
noreply at macports.org
Tue Feb 7 08:14:10 UTC 2023
#65710: graphene @1.10.8_0+universal: graphene-1.0.pc differs and cannot be merged
-----------------------+---------------------------------
Reporter: thetrial | Owner: dbevans
Type: defect | Status: assigned
Priority: Normal | Milestone:
Component: ports | Version: 2.7.2
Resolution: | Keywords: elcapitan legacy-os
Port: graphene |
-----------------------+---------------------------------
Comment (by kencu):
SSE2 has been disabled for i386 builds for graphene by upstream, as
mentioned above, apparently because on linux i386 there was not always 16
byte alignment for the variables, so there were segfaults.
Darwin/MacOS always guarantees at least 16byte alignment for malloc'd
variables, so this cannot (should not) happen on Darwin.
For a number of years, since 2018, MacPorts built graphene with SSE2
support enabled in both the i386 and x86_64 builds. This happened because
of the exact same issue with muniversal we are seeing in this ticket, and
Marcus just disabled all the SSE2 special tests in graphene and let the
compiler defines sort it out:
https://github.com/macports/macports-
ports/commit/72c820b27ee817a55317ae20d8417a818a56af61
and this worked, it seemed, and everyone was happy.
(The test suite in graphene has never worked in MacPorts, so we could
never prove it was OK, but nobody complained at least).
Recently Dave updated graphene and removed the disabler on this x86_64
test, so we are back at square one with the same exact problem building
universal as before.
I would propose we again disable the x64_64 test in meson.build again (10
seconds max, trivial to do) and let the {{{__SSE2__}}} compiler define
sort it out like it has all these past years for us.
That seems better to me that disabling the SIMD instruction set needlessly
on these older CPUs that probably desperately need it, and we used the
SIMD i386 instructions for years to support that idea.
--
Ticket URL: <https://trac.macports.org/ticket/65710#comment:9>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list