[MacPorts] #66751: snac @2.18: use the right compiler and flags

[MacPorts]

#66751: snac @2.18: use the right compiler and flags
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  artkiver
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.8.0
Resolution:              |   Keywords:
      Port:  snac        |
-------------------------+----------------------

Comment (by artkiver):

 So, snac 2.19 was released, which reminded me to look into this in more
 detail.

 https://guide.macports.org/chunked/reference.portgroup.html is a bit
 sparse as far as information on the makefile PortGroup.

 https://github.com/macports/macports-
 ports/blob/master/_resources/port1.0/group/makefile-1.0.tcl

 Is I guess a useful reference insomuch as it is the TCL being invoked,
 though I am not sure how well I am parsing it as a human.

 Regardless, doing some minor edits to the Portfile

 e.g.
 PortGroup           makefile 1.0

 Still seems to install OK after I do a port -v clean.

 In reading, I thought about adding:


 {{{
 build.args-append   CFLAGS=-g -Wall -D st_mtim=st_mtimespec

 }}}

 And it doesn't seem to cause harm?

 I even explored removing the


 {{{
 patchfiles          Makefile.patch
 post-patch          {reinplace "s|/usr/local|${prefix}|g"
 ${worksrcpath}/Makefile}
 }}}

 As well as attempting to add some other things to
 build.args-append

 Such as:


 {{{
 PREFIX=/opt/local
 and PREFIX_MAN=/opt/local/share/man

 }}}

 But I may have been a bit too ambitious with some of that and seemed to
 get some errors back when running lint --nitpick for example.

 So, at the moment, I have a rather more conservative Portfile with some
 changes, which seems to function OK; but I am not sure if it addresses all
 the issues raised here.

 I'm attaching it for reference though. Doubtlessly, it can be improved
 upon somewhat, but I figure best to update the Trac ticket for the time
 being as no one has replied on IRC  to my inquiry yet.

-- 
Ticket URL: <https://trac.macports.org/ticket/66751#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS