[MacPorts] #66153: cdparanoia: Assertion failed: (range.location + range.length <= dataLength), function __CFDataValidateRange, file CFData.c, line 235

[MacPorts]

#66153: cdparanoia: Assertion failed: (range.location + range.length <=
dataLength), function __CFDataValidateRange, file CFData.c, line 235
-------------------------+---------------------------
  Reporter:  Jtaillan    |      Owner:  jeremyhu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:
Resolution:              |   Keywords:  ventura arm64
      Port:  cdparanoia  |
-------------------------+---------------------------

Comment (by kencu):

 Yup, good find:

 {{{
 % uname -a
 Darwin MacBookPro-2012 22.2.0 Darwin Kernel Version 22.2.0: Fri Nov 11
 02:08:47 PST 2022; root:xnu-8792.61.2~4/RELEASE_X86_64 x86_64
 }}}

 {{{
 % cdparanoia -A
 cdparanoia III release 10.2 (September 11, 2008)

 Using cdda library version: 10.2
 Using paranoia library version: 10.2
 track_num = 160 start sector 4350 msf: 1,0,0
 track_num = 161 start sector 58350 msf: 13,0,0
 track_num = 162 start sector 227540 msf: 50,35,65
 track_num = 1 start sector 0 msf: 0,2,0
 track_num = 2 start sector 13887 msf: 3,7,12
 track_num = 3 start sector 27852 msf: 6,13,27
 track_num = 4 start sector 48390 msf: 10,47,15
 track_num = 5 start sector 70827 msf: 15,46,27
 track_num = 6 start sector 86352 msf: 19,13,27
 track_num = 7 start sector 102900 msf: 22,54,0
 track_num = 8 start sector 117642 msf: 26,10,42
 track_num = 9 start sector 136590 msf: 30,23,15
 track_num = 10 start sector 152585 msf: 33,56,35
 track_num = 11 start sector 165180 msf: 36,44,30
 track_num = 12 start sector 185457 msf: 41,14,57
 track_num = 13 start sector 204627 msf: 45,30,27

 Attempting to set cdrom to full speed...
         drive returned OK.

 }}}

 I changed just one line in osx_interface.patch, from:

 {{{
 +  buf_len = CFDataGetLength(data) + 1;
 }}}
 to
 {{{
 +  buf_len = CFDataGetLength(data);
 }}}

 I suppose we should test that on at least one or two older systems, but it
 seems a simple, solid fix so should be no problems. Presumably Ventura is
 increasingly strict about buffer overruns.

-- 
Ticket URL: <https://trac.macports.org/ticket/66153#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS