[MacPorts] #67774: libgit2-devel @1.7.0: builds fail for 10.8 thru 10.12: use of undeclared identifier 'errSSLNetworkTimeout'

MacPorts noreply at macports.org
Thu Jul 20 11:39:09 UTC 2023


#67774: libgit2-devel @1.7.0: builds fail for 10.8 thru 10.12: use of undeclared
identifier 'errSSLNetworkTimeout'
---------------------+---------------------------
 Reporter:  mascguy  |      Owner:  mascguy
     Type:  defect   |     Status:  assigned
 Priority:  Normal   |  Milestone:
Component:  ports    |    Version:  2.8.1
 Keywords:           |       Port:  libgit2-devel
---------------------+---------------------------
 For version 1.7.0, upstream now references constant `errSSLNetworkTimeout`
 in their SSL-related code. And that's only available in 10.13+. That
 changes was made by commit:

 https://github.com/libgit2/libgit2/commit/fad90428970e332153027773b517a1606c0efa1f

 via [https://github.com/libgit2/libgit2/pull/6535 PR 6535 - Introduce
 timeouts on sockets]

 Use of the constant is limited to source file
 `src/libgit2/streams/stransport.c`.

 While used in two places, one example of the change is as follows.

 Previous logic:

 {{{
 if (ret < 0) {
         st->error = ret;
         return -36; /* ioErr */
 }
 }}}

 New logic:

 {{{
 if (ret < 0) {
         st->error = ret;
         return (ret == GIT_TIMEOUT) ?
                errSSLNetworkTimeout :
                -36 /* ioErr */;
 }
 }}}

-- 
Ticket URL: <https://trac.macports.org/ticket/67774>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list