[MacPorts] #67870: libarchive @3.7.0: build fails on Tiger for several reasons

[MacPorts]

#67870: libarchive @3.7.0: build fails on Tiger for several reasons
-------------------------+--------------------
  Reporter:  kencu       |      Owner:  (none)
      Type:  defect      |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:
Resolution:              |   Keywords:  Tiger
      Port:  libarchive  |
-------------------------+--------------------
Description changed by kencu:

Old description:

> there are at least two issues on Tiger
>
> {{{
> :info:build unzip/bsdunzip.c: In function 'match_pattern':
> :info:build unzip/bsdunzip.c:325: warning: implicit declaration of
> function 'STAILQ_FOREACH'
> :info:build unzip/bsdunzip.c:325: error: expected ';' before '{' token
> :info:build unzip/bsdunzip.c:334: warning: no return statement in
> function returning non-void
> :info:build unzip/bsdunzip.c: In function 'extract_file':
> :info:build unzip/bsdunzip.c:800: warning: implicit declaration of
> function 'lchmod'
> :info:build make[1]: *** [unzip/bsdunzip-bsdunzip.o] Error 1
> }}}
>
> both of these are in legacysupport, however legacysupport has
> traditionally not worked well with libarchive.
>
> The new fixes in legacy support devel work better with libarchive, or the
> functions could be patched in directly as has been done recently. I did
> the STAILQ_FOREACH one, and I'll attach that, but I didn't do lchmod and
> just used legacy-support-devel instead.
>
> This port does not behave too well when running the tests on Tiger -- it
> leaves behind deep directories in the .tmp/ testing directory that are
> hard to remove later.
>
> In the end, I wound up pegging libarchive at the previous version for the
> time being while this is sorted out.

New description:

 there are at least two issues on Tiger

 {{{
 :info:build unzip/bsdunzip.c: In function 'match_pattern':
 :info:build unzip/bsdunzip.c:325: warning: implicit declaration of
 function 'STAILQ_FOREACH'
 :info:build unzip/bsdunzip.c:325: error: expected ';' before '{' token
 :info:build unzip/bsdunzip.c:334: warning: no return statement in function
 returning non-void
 :info:build unzip/bsdunzip.c: In function 'extract_file':
 :info:build unzip/bsdunzip.c:800: warning: implicit declaration of
 function 'lchmod'
 :info:build make[1]: *** [unzip/bsdunzip-bsdunzip.o] Error 1
 }}}

 both of these are in legacysupport, however legacysupport has
 traditionally not worked well with libarchive #61746.

 The new fixes in legacy support devel work better with libarchive, or the
 functions could be patched in directly as has been done recently. I did
 the STAILQ_FOREACH one, and I'll attach that, but I didn't do lchmod and
 just used legacy-support-devel instead.

 This port does not behave too well when running the tests on Tiger -- it
 leaves behind deep directories in the .tmp/ testing directory that are
 hard to remove later.

 In the end, I wound up pegging libarchive at the previous version for the
 time being while this is sorted out.

--

-- 
Ticket URL: <https://trac.macports.org/ticket/67870#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS