[MacPorts] #67656: svndigest 0.11

[MacPorts]

#67656: svndigest 0.11
-------------------------+---------------------------------
  Reporter:  peter31042  |      Owner:  ryandesign
      Type:  update      |     Status:  accepted
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:
Resolution:              |   Keywords:  haspatch maintainer
      Port:  svndigest   |
-------------------------+---------------------------------

Comment (by ryandesign):

 I see that help2man is used:

 {{{
 checking whether to use help2man... yes
 }}}

 so I'll add a build dependency on the help2man port. macOS includes
 help2man but using the MacPorts version reduces surprises by ensuring
 we're using the same version on every macOS version.

 The build fails when gsl is not installed:

 {{{
 ./yat/utility.h:38:10: fatal error: 'gsl/gsl_math.h' file not found
 #include <gsl/gsl_math.h>
          ^~~~~~~~~~~~~~~~
 }}}

 so I can add that build dependency too. Or perhaps even better, can that
 gsl `#include` line be removed? svndigest builds fine and tests pass
 without gsl installed when that line is removed.

 {{{
 ============================================================================
 Testsuite summary for svndigest 0.11
 ============================================================================
 # TOTAL: 41
 # PASS:  14
 # SKIP:  27
 # XFAIL: 0
 # FAIL:  0
 # XPASS: 0
 # ERROR: 0
 ============================================================================
 }}}

 I see that the gsl `#include` was already
 [https://dev.thep.lu.se/yat/changeset/3938/trunk/yat/utility/utility.h
 removed from upstream yat 3 years ago] but svndigest bundles a 10.5-year-
 old yat. That commit also removed the use of `M_LN2` which is defined by
 gsl/gsl_math.h (if not already defined):

 {{{
 #ifndef M_LN2
 #define M_LN2      0.69314718055994530941723212146      /* ln(2) */
 #endif
 }}}

 My system's math.h already defines `M_LN2` on macOS 12 (and I checked a
 Mac OS X 10.6 system and it appears to as well) but if this is the only
 thing from gsl/gsl_math.h that was being used in yat and if support for
 systems where math.h doesn't define `M_LN2` is important maybe that
 `#ifndef` block can be used in yat/utility.h instead of including
 gsl/gsl_math.h.

 Would updating svndigest to use a newer yat be useful? There have been
 dozens of releases of yat since the one included in svndigest.

-- 
Ticket URL: <https://trac.macports.org/ticket/67656#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS