[MacPorts] #67574: dia @0.97.3_6 is broken by icu update

[MacPorts]

#67574: dia @0.97.3_6 is broken by icu update
------------------------+-----------------------
  Reporter:  fhgwright  |      Owner:  fhgwright
      Type:  defect     |     Status:  closed
  Priority:  Normal     |  Milestone:
 Component:  ports      |    Version:  2.8.1
Resolution:  fixed      |   Keywords:
      Port:  dia        |
------------------------+-----------------------

Comment (by fhgwright):

 Replying to [comment:5 ryandesign]:
 > Replying to [comment:4 fhgwright]:
 > > Given that it doesn't directly call `icu`, the following seems
 suspect:
 > > {{{
 > > # required for for ICU
 > > compiler.cxx_standard     2011
 > > configure.cxxflags-append -std=c++11
 > > }}}
 >
 > As I recall, the ICU headers require C++11 or newer so anything
 including those headers needs at least a C++11 compiler and to be
 compiling in C++11 mode or newer too. So these lines are correct and
 should not be removed.

 Except that `dia` doesn't use the `icu` headers.  I verified that `dia`
 can build with the `icu` headers (`/opt/local/include/unicode/`) renamed
 out of sight (but not with `icu` deactivated, since that breaks
 `xsltproc`).

 The C++11 requirement was added by commit
 8cf9b206c3c2fcca0e0f6ee2a46f47bc828a3cb7, which modified 64 files for an
 `icu` update.  Maybe `dia` was a victim of "human overlinking".

 I left it alone based on the risk vs. benefit of changing it, not because
 I think that's the most correct result.

-- 
Ticket URL: <https://trac.macports.org/ticket/67574#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS