[MacPorts] #68710: py-matplotlib: automated build failures on High Sierra, Mojave, Catalina (was: py39-matplotlib: automated build failures on High Sierra, Mojave, Catalina)

[MacPorts]

#68710: py-matplotlib: automated build failures on High Sierra, Mojave, Catalina
----------------------------------+------------------------
  Reporter:  thomasrussellmurphy  |      Owner:  reneeotten
      Type:  defect               |     Status:  accepted
  Priority:  Normal               |  Milestone:
 Component:  ports                |    Version:
Resolution:                       |   Keywords:
      Port:  py-matplotlib        |
----------------------------------+------------------------
Changes (by reneeotten):

 * status:  new => accepted
 * owner:  (none) => reneeotten
 * port:  py39-matplotlib => py-matplotlib
 * cc: reneeotten (removed)


Comment:

 It looks like the problem is:
 {{{
 building 'matplotlib.backends._macosx' extension
 creating
 build/temp.macosx-10.14-x86_64-cpython-39/matplotlib.backends._macosx
 creating
 build/temp.macosx-10.14-x86_64-cpython-39/matplotlib.backends._macosx/src
 /opt/local/var/macports/build
 /_opt_bblocal_var_buildworker_ports_build_ports_python_py-
 matplotlib/py39-matplotlib/work/compwrap/cc/usr/bin/clang -Wno-unused-
 result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g
 -fwrapv -O3 -Wall -pipe -Os
 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk -arch
 x86_64 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk
 -I/opt/local/Library/Frameworks/Python.framework/Versions/3.9/include/python3.9
 -c src/_macosx.m -o
 build/temp.macosx-10.14-x86_64-cpython-39/matplotlib.backends._macosx/src/_macosx.o
 -Werror -fvisibility=hidden -flto
 src/_macosx.m:48:49: error: suggest braces around initialization of
 subobject [-Werror,-Wmissing-braces]
 static struct sigaction originalSigintAction = {0};
                                                 ^
                                                 {}
 src/_macosx.m:61:42: error: suggest braces around initialization of
 subobject [-Werror,-Wmissing-braces]
         struct sigaction customAction = {0};
                                          ^
                                          {}
 2 errors generated.
 }}}

 I cannot tell if this is really an error that should be fixed upstream (I
 kind of doubt it) or it's just something that some versions of Clang
 complain about... The latter case explains why it build on most systems,
 but not all.

 I notice as well that the build is using {{{-Werror}}} as an flag/option,
 which is AFAIK not really we typically use in MacPorts. So I could/would
 look into where that is added in the build and just remove it or -perhaps
 better- replace it by {{{-Wextra}}} as is being done in some other ports.

 I will take a look but cannot promise on when I'll get to it.

-- 
Ticket URL: <https://trac.macports.org/ticket/68710#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS