[MacPorts] #68570: serf1 @1.3.10: Doesn't use -arch flags (was: serf1 fails to build - wrong architecture on 10.5 64bit ?)

[MacPorts]

#68570: serf1 @1.3.10: Doesn't use -arch flags
-----------------------+------------------------
  Reporter:  rmottola  |      Owner:  ryandesign
      Type:  defect    |     Status:  accepted
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:
Resolution:            |   Keywords:
      Port:  serf1     |
-----------------------+------------------------
Changes (by ryandesign):

 * cc: barracuda156 (added)
 * status:  new => accepted
 * owner:  (none) => ryandesign


Comment:

 Before serf1 used the makefile portgroup, it supplied CC, CPPFLAGS,
 CFLAGS, and LINKFLAGS as arguments to scons. After including the makefile
 portgroup, it is still setting CC as an argument, but CPPFLAGS and CFLAGS
 are now being supplied as environment variables (which scons is ignoring
 because it expected arguments not environment variables) and the makefile
 portgroup is also setting LDFLAGS (which scons is ignoring because it
 expected an environment variable named LINKFLAGS).

 The makefile portgroup can be told to supply CPPFLAGS and CFLAGS as
 arguments instead of environment variables by using `makefile.override-
 append CFLAGS CPPFLAGS` however there is no way to tell the makefile
 portgroup to use the name LINKFLAGS instead of LDFLAGS; LINKFLAGS will
 have to be set manually in `build.args`. It's therefore simplest to revert
 [f2d6387f1c3c27ae29d5bf7414503793f778392c/macports-ports] entirely.

 Some effort to fix the missing arch flags was made in
 [a4ee3e38474931392a9ae37590242e7138f6225c/macports-ports] but only on Mac
 OS X 10.6 when building for ppc. That should be reverted as well since it
 won't be necessary after fixing it properly for all systems.

-- 
Ticket URL: <https://trac.macports.org/ticket/68570#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS