[MacPorts] #68148: libgit2 @1.7.1: builds fail with xcode clang 6 and earlier: error: unknown type name 'inline', from legacy-support header 'dirent.h' (was: libgit2 @1.7.1: builds fail with xcode clang 6 and earlier: error: unknown type name 'inline')

[MacPorts]

#68148: libgit2 @1.7.1: builds fail with xcode clang 6 and earlier: error: unknown
type name 'inline', from legacy-support header 'dirent.h'
----------------------+----------------------
  Reporter:  mascguy  |      Owner:  mascguy
      Type:  defect   |     Status:  assigned
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.8.1
Resolution:           |   Keywords:
      Port:  libgit2  |
----------------------+----------------------
Changes (by mascguy):

 * cc: cjones051073, catap (added)


Comment:

 Replying to [comment:2 mascguy]:
 > Unfortunately blacklisting clang doesn't cut the mustard either. Do we
 need to patch the project's CMake files, and specify the C standard as 99?
 Or...?

 Given that the failure relates to a header provided by `legacy-support` -
 which AFAIK, we haven't seen cause any such issues elsewhere - this is
 curious to be sure. (And I'm thinking it's the project specifying C 90 to
 Clang.) Particularly when `libgit2-devel` 1.7.1 built just fine three
 weeks ago, with `legacy-support`. And the latter's header - `dirent.h` -
 hasn't changed.

 Fortunately this is only affecting 10.9 and earlier, so the fallout isn't
 as bad as it could be. Would still like to get it resolved ASAP though.

-- 
Ticket URL: <https://trac.macports.org/ticket/68148#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS