[MacPorts] #68167: WIP new Portfile Bonzomatic
MacPorts
noreply at macports.org
Sat Sep 16 20:51:21 UTC 2023
#68167: WIP new Portfile Bonzomatic
-------------------------+--------------------
Reporter: artkiver | Owner: (none)
Type: submission | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords:
Port: Bonzomatic |
-------------------------+--------------------
Comment (by artkiver):
Replying to [comment:1 ryandesign]:
Thanks for taking a look at this!
> Replying to [ticket:68167 artkiver]:
> > Pending the merge of this PR:
https://github.com/Gargaj/Bonzomatic/pull/177
>
> We don't want the CMakeLists.txt to set `CMAKE_OSX_ARCHITECTURES` at all
because the portgroup already does that correctly. I don't remember if the
portgroup will override what's in CMakeLists.txt. If it doesn't, what's in
CMakeLists.txt will have to be removed with a patch.
>
I appreciate that perspective. I was thinking along similar lines insomuch
as it might be possible to build on PPC as well (though I haven't dug up
one of my PowerBooks from storage to test, I suppose I can!). The initial
impetus for the issue I submitted to the upstream project was when I went
to build this from source on an Apple Silicon Mac, it was prompting me to
install Rosetta (2) after launching, which shouldn't be necessary, though
the PR I linked to previously maybe isn't the most appropriate way to
handle such things for MacPorts either given we support more than just
Intel and Apple Silicon.
>
> > I seem to be running into some issues with the cmake Portgroup's
default destroot.target {install/fast}
> >
> > Is there a way to override that?
>
> Undoubtedly. Looking into the portgroup, it sets the default
`destroot.target` to `install/fast`:
>
> https://github.com/macports/macports-
ports/blob/d4eee4d269b1246d6d035d1bc5b08cb9bc659372/_resources/port1.0/group/cmake-1.1.tcl#L87
>
> You can surely set `destroot.target` to something else in your Portfile
if you want. It's surprising that that should be necessary however; as far
as I know it's a standard cmake makefile target that should appear in all
makefiles generated by cmake.
Yeah, I experimented with some different parameters for destroot.target
but kept running into errors; I guess i still haven't wrapped my head
around the install/fast default nor what a better alternative would be in
this instance.
>
> The CMakeLists.txt says this software requires C++14 when building on
macOS so you'd better indicate that in the Portfile with
`compiler.cxx_standard 2014`.
>
Ah, good catch! I'll update that.
> Strange `homepage`. Don't you think homepage the github portgroup sets
for you is better?
Very possibly! I contemplated that approach too; I think since this
project has sort of evolved out of the demo-scene that is why it
references the pouet.net page; but as far as code updates GitHub seems to
be where development is actively taking place these days.
--
Ticket URL: <https://trac.macports.org/ticket/68167#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list