[MacPorts] #68178: rav1e: build fails due to git_allocator missing members
MacPorts
noreply at macports.org
Wed Sep 20 23:30:19 UTC 2023
#68178: rav1e: build fails due to git_allocator missing members
---------------------+----------------------
Reporter: lukaso | Owner: mascguy
Type: defect | Status: assigned
Priority: Normal | Milestone:
Component: ports | Version: 2.8.1
Resolution: | Keywords:
Port: rav1e |
---------------------+----------------------
Comment (by mascguy):
Replying to [comment:12 lukaso]:
> This port has been broken for over a month now for one reason or
another. It was also last broken in december 2022. Maybe it's time to cut
`rav1e` loose? I tried to remove the dependency in the GIMP build by
excluding it from `libheif` but it appears to be included in some other
port that somehow I am including so that didn't help.
Okay, just tried building `rav1e` from source. And sure enough, our port
is currently broken.
But let me stress that's it's very likely ''our port'' that's broken, not
upstream.
Why do I say that? Well, take a look at the portfile for `rav1e`, and
specifically the crate for `libgit2-sys`:
{{{
libgit2-sys 0.14.2+1.5.1
}}}
That crate corresponds to `libgit2` 1.5.1. Whereas `git2-rs` upstream has
released later releases, including the latest: `libgit2-sys-0.16.1+1.7.1`.
And the latter corresponds to the latest `libgit2` release. (Per the
`+1.7.1` suffix.) Which is what we should probably be used. Though perhaps
one of the previous releases, corresponding to `libgit2` 1.6.x, might work
too. Dunno without more research/testing.
In any case, updating that crate, likely involves updating others as well.
Perhaps that's automated via a MacPorts script somewhere? (Not a Rust guru
here, otherwise I would have fixed this by now.)
So I'm quite certain this is 100% our issue.
As for downgrading `libgit2`: Simply reverting one commit isn't going to
cut it. We'd also need to downgrade `py-pygit2`, and a number of others.
And then rebuild every dependent - including `rust` and `cargo`, along
with numerous other dependents. (As the downgrade would break the ABI.) So
no, not going to happen, when it seems very clear the `rav1e` port is the
one that needs to be fixed.
--
Ticket URL: <https://trac.macports.org/ticket/68178#comment:13>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list