[MacPorts] #68278: openjdk17: missed dependency to libiconv

[MacPorts]

#68278: openjdk17: missed dependency to libiconv
------------------------+--------------------
  Reporter:  catap      |      Owner:  (none)
      Type:  defect     |     Status:  new
  Priority:  Normal     |  Milestone:
 Component:  ports      |    Version:
Resolution:             |   Keywords:
      Port:  openjdk17  |
------------------------+--------------------

Comment (by breun):

 For the `openjdk17` port `lib instrument.dylib` indeed has
 `/opt/local/lib/libiconv.2.dylib` in its list of used shared libraries:

 {{{
 ❯ otool -L
 /opt/local/Library/Java/JavaVirtualMachines/openjdk17/Contents/Home/lib/libinstrument.dylib
 /opt/local/Library/Java/JavaVirtualMachines/openjdk17/Contents/Home/lib/libinstrument.dylib:
         @rpath/libinstrument.dylib (compatibility version 1.0.0, current
 version 1.0.0)
         @rpath/libjava.dylib (compatibility version 1.0.0, current version
 1.0.0)
         @rpath/libjvm.dylib (compatibility version 1.0.0, current version
 1.0.0)
         /opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current
 version 1.3.0)
         @rpath/libjli.dylib (compatibility version 1.0.0, current version
 1.0.0)
         /opt/local/lib/libiconv.2.dylib (compatibility version 9.0.0,
 current version 9.1.0)
         /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa
 (compatibility version 1.0.0, current version 24.0.0)
         /System/Library/Frameworks/Security.framework/Versions/A/Security
 (compatibility version 1.0.0, current version 61040.1.3)
 /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices
 (compatibility version 1.0.0, current version 64.0.0)
         /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current
 version 1336.0.0)
 }}}

 The pre-built JVM ports I maintain reference `/usr/lib/libiconv.2.dylib`
 instead of `/opt/local/lib/libiconv.2.dylib`, and no linking errors are
 reported when installing them on a system without the `libiconv` port
 installed, even though there is no `/usr/lib/libiconv.2.dylib` file on my
 system.

 But I also see `/usr/lib/libSystem.B.dylib` in the list of used shared
 libraries for both `openjdk17` and `openjdk17-zulu`, and I don't have that
 file on my system, but there are no link errors reported for that. I am
 not very familiar with how shared dylib files work though.

-- 
Ticket URL: <https://trac.macports.org/ticket/68278#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS