[MacPorts] #69692: ImageMagick7 @7.1.1-29_1 [-x11]: Installation/build fails

[MacPorts]

#69692: ImageMagick7 @7.1.1-29_1 [-x11]: Installation/build fails
---------------------------+------------------------
  Reporter:  frkd-dev      |      Owner:  ryandesign
      Type:  defect        |     Status:  accepted
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:
Resolution:                |   Keywords:  haspatch
      Port:  ImageMagick7  |
---------------------------+------------------------
Changes (by ryandesign):

 * keywords:   => haspatch
 * owner:  (none) => ryandesign
 * status:  new => accepted
 * cc: Dave-Allured (added)


Old description:

> The installation of ImageMagick7 fails with the following errors:
>

> {{{
> :info:build Magick++/lib/Color.cpp:246:17: error: use of undeclared
> identifier 'PixelPacket'
> :info:build       _pixel = (PixelPacket *)NULL;
> :info:build                 ^
> :info:build Magick++/lib/Color.cpp:246:30: error: expected expression
> :info:build       _pixel = (PixelPacket *)NULL;
> :info:build                              ^
> :info:build 2 errors generated.
> }}}
>
> This error is introduced by the port's patch for "Color.cpp" file [1].
>
> The upstream is using now the "PixelInfo" type instead of "PixelPacket",
> and I believe that causes the error.
>
> The patch itself can be retired very soon since the upstream a couple of
> days ago ditched "nullptr" in favor of "(PixelInfo*)NULL" type casting
> [2]. This change wasn't released yet but we should expect this soon.
>

> [1]: https://github.com/macports/macports-
> ports/blob/master/graphics/ImageMagick7/files/Color.cpp.patch
>
> [2]:
> https://github.com/ImageMagick/ImageMagick/blob/main/Magick%2B%2B/lib/Color.cpp#L246

New description:

 The installation of ImageMagick7 fails with the following errors:


 {{{
 :info:build Magick++/lib/Color.cpp:246:17: error: use of undeclared
 identifier 'PixelPacket'
 :info:build       _pixel = (PixelPacket *)NULL;
 :info:build                 ^
 :info:build Magick++/lib/Color.cpp:246:30: error: expected expression
 :info:build       _pixel = (PixelPacket *)NULL;
 :info:build                              ^
 :info:build 2 errors generated.
 }}}

 This error is introduced by the port's patch for "Color.cpp" file ![1].

 The upstream is using now the `PixelInfo` type instead of `PixelPacket`,
 and I believe that causes the error.

 The patch itself can be retired very soon since the upstream a couple of
 days ago ditched `nullptr` in favor of `(PixelInfo*)NULL` type casting
 ![2]. This change wasn't released yet but we should expect this soon.


 ![1]: https://github.com/macports/macports-
 ports/blob/master/graphics/ImageMagick7/files/Color.cpp.patch

 ![2]:
 https://github.com/ImageMagick/ImageMagick/blob/main/Magick%2B%2B/lib/Color.cpp#L246

--

Comment:

 Oh, shoot, sorry, I didn't notice that difference between 6 and 7 when I
 added the patch.

-- 
Ticket URL: <https://trac.macports.org/ticket/69692#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS