[MacPorts] #69831: nethack: enable curses graphics (was: games/nethack enable curses graphics)

[MacPorts]

#69831: nethack: enable curses graphics
-----------------------------+----------------------
  Reporter:  jnielsendotnet  |      Owner:  jflude
      Type:  enhancement     |     Status:  assigned
  Priority:  Normal          |  Milestone:
 Component:  ports           |    Version:
Resolution:                  |   Keywords:  haspatch
      Port:  nethack         |
-----------------------------+----------------------
Changes (by ryandesign):

 * keywords:   => haspatch


Comment:

 I'm surprised this didn't already work since the port already has a
 dependency on the ncurses port.

 Assuming I understand you correctly and this changes the runtime behavior
 of the program, the `revision` must be increased.

 This port has a nethack343 subport, so make sure this fix is applied both
 to the main port and to the nethack343 subport, assuming each one needs
 it, and that the `revision` of each one that needs it is increased.

 Specifying CFLAGS manually like this is not great. In fact it highlights
 that the port hasn't been using the CFLAGS that MacPorts wants all ports
 to use (for example the default optimization flags), which are in
 `${configure.cflags}`, just as the CPPFLAGS that should be used are in
 `${configure.cppflags}` and the LDFLAGS that should be used are in
 `${configure.ldflags}`. The makefile portgroup can help Portfiles with
 nonstandard Makefiles use these flags properly, or it can be done
 manually. Then adding to CFLAGS is a simple matter of e.g. `configure
 .cflags-append -I../include -DCURSES_GRAPHICS -DNOTPARMDECL`, except that
 these really look like CPPFLAGS to me, not CFLAGS.

 The nethack343 subport even manually adds `-O2` optimization flags and
 performs some convoluted gyrations in the menucolors variant to add more
 CFLAGS which would be simplified by making the portfile use the standard
 variables.

-- 
Ticket URL: <https://trac.macports.org/ticket/69831#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS