[MacPorts] #71488: php83-rar @4.2.0: rararch.c:547:12: error: conflicting types for 'rararch_count_elements'
MacPorts
noreply at macports.org
Sun Dec 8 13:53:33 UTC 2024
#71488: php83-rar @4.2.0: rararch.c:547:12: error: conflicting types for
'rararch_count_elements'
----------------------------+------------------------
Reporter: slightlybeige | Owner: ryandesign
Type: defect | Status: assigned
Priority: Normal | Milestone:
Component: ports | Version: 2.10.5
Resolution: | Keywords:
Port: php83-rar |
----------------------------+------------------------
Comment (by ryandesign):
If changing the second parameter from `long` to `zend_long` is correct,
then further changes may be needed in that function.
For example, here, perhaps `ZEND_LONG_MAX` is needed instead of
`LONG_MAX`:
{{{#!c
if (entry_count > LONG_MAX)
entry_count = (size_t) LONG_MAX;
}}}
And here, maybe it should cast to `zend_long` instead of `long`:
{{{#!c
*count = (long) entry_count;
}}}
It's also important to remember that this module works with old versions
of PHP so any changes need to remain compatible with old PHP versions. I
don't know whether the proposed these changes work on old PHP.
The developers of this module are best equipped to know how their code
needs to be changed to fix the error which is why I suggest reporting it
to them. Unfortunately there have been no commits to their repository in
three years and they have not yet acknowledged or included the
[https://github.com/cataphract/php-rar/pull/18 php 8.1 and 8.2
compatibility fixes] that I already added to the port so I'm not
optimistic that we will get any response from them.
--
Ticket URL: <https://trac.macports.org/ticket/71488#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list