[MacPorts] #71631: pngcrush @1.8.13: fatal error: 'fp.h' file not found (was: pngcrush fails to build on Sequoia 15.1 / Apple Silicon)

[MacPorts]

#71631: pngcrush @1.8.13: fatal error: 'fp.h' file not found
-----------------------+----------------------
  Reporter:  kpreid    |      Owner:  nerdling
      Type:  defect    |     Status:  accepted
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:  2.10.5
Resolution:            |   Keywords:
      Port:  pngcrush  |
-----------------------+----------------------
Changes (by ryandesign):

 * cc: kencu (added)


Comment:

 Replying to [ticket:71631 kpreid]:
 > pngcrush fails to build. The fatal error is:
 >
 > {{{
 > :info:build In file included from pngcrush.c:1709:
 > :info:build In file included from ./png.c:14:
 > :info:build ./pngpriv.h:518:16: fatal error: 'fp.h' file not found
 > :info:build   518 | #      include <fp.h>
 > :info:build       |                ^~~~~~
 > }}}
 >
 > Judging by clues found in a web search, this seems to be an
 incompatibility in an old version of libpng that seems to be embedded in
 the pngcrush sources. Perhaps it is feasible to patch.

 I didn't find the upstream bug report for this problem. If you can't find
 one either, please file one so they can fix it.


 Replying to [comment:2 kencu]:
 > one possible solution is to use the {{{Makefile-nolib}}}, which uses the
 installed versions of png and zlib.
 >
 > Doing that needs a couple of small tweaks to the include paths, and use
 this debian patch:
 >
 > https://salsa.debian.org/debian-phototools-
 team/pngcrush/-/blob/master/debian/patches/ignore_PNG_IGNORE_ADLER32.patch?ref_type=heads
 >
 >
 > and presto:
 >
 > {{{
 > % port -v installed pngcrush
 > The following ports are currently installed:
 >   pngcrush @1.8.13_0 (active) requested_variants='' platform='darwin 24'
 archs='arm64' date='2024-12-24T00:02:39-0800'
 >
 >
 > % otool -L /opt/local/bin/pngcrush
 > /opt/local/bin/pngcrush:
 >       /opt/local/lib/libpng16.16.dylib (compatibility version 61.0.0,
 current version 61.0.0)
 >       /opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current
 version 1.3.1)
 >       /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current
 version 1351.0.0)
 > }}}

 That seems like a great idea. Since you've already done the work, would
 you like to submit the pull request? Don't forget to increase the port's
 revision.

-- 
Ticket URL: <https://trac.macports.org/ticket/71631#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS