[MacPorts] #65525: grpc fails on 10.6.8: error: missing binary operator before token "("
MacPorts
noreply at macports.org
Mon Dec 30 04:20:54 UTC 2024
#65525: grpc fails on 10.6.8: error: missing binary operator before token "("
---------------------------+--------------------------
Reporter: barracuda156 | Owner: barracuda156
Type: defect | Status: closed
Priority: Normal | Milestone:
Component: ports | Version: 2.7.2
Resolution: fixed | Keywords:
Port: grpc |
---------------------------+--------------------------
Changes (by ryandesign):
* cc: jmroot, ryandesign (added)
Comment:
Replying to [comment:1 jmroot]:
> The code in question should look like this:
> {{{
> #if defined(__has_feature)
> #if __has_feature(cxx_thread_local)
> #define GPR_PTHREAD_TLS 1
> #endif
> #endif
> }}}
Isn't that backwards? Previously the code was:
{{{
#if !(defined(__has_feature) && __has_feature(cxx_thread_local))
#define GPR_PTHREAD_TLS 1
#endif
}}}
In other words, it would define `GPR_PTHREAD_TLS` (meaning that it should
provide a compatibility TLS implementation using pthread) if the C++
compiler does ''not'' support thread-local storage.
Your proposed change which was committed to the port defines
`GPR_PTHREAD_TLS` if the C++ compiler ''does'' support TLS.
--
Ticket URL: <https://trac.macports.org/ticket/65525#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS
More information about the macports-tickets
mailing list