[MacPorts] #67446: pika @0.22.1: some failures with clang builds

[MacPorts]

#67446: pika @0.22.1: some failures with clang builds
---------------------------+--------------------------
  Reporter:  barracuda156  |      Owner:  mascguy
      Type:  defect        |     Status:  assigned
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:  2.9.1
Resolution:                |   Keywords:  x86_64, i386
      Port:  pika          |
---------------------------+--------------------------

Comment (by kencu):

 these flags in legacysupport 1.1:
 {{{
 append ls_cache_cppflags " -nostdinc++
 -isystem${prefix}/include/libcxx/v1"
 }}}

 indeed should be only CXXFLAGS, not CPPFLAGS. Passing those to anything
 but the CXX compiler can only cause problems.

 If there are builds that are not using CXXFLAGS for CXXFLAGS, but are
 using CPPFLAGS for CXXFLAGS, then those would have to be fixed to use the
 proper CXXFLAGS as they are discovered.

 Fixing that will require some retooling in legacysupport 1.1, as there is
 currently no {{{MACPORTS_LEGACY_SUPPORT_CXXFLAGS}}}, and also there are a
 few other places I see that {{{MACPORTS_LEGACY_SUPPORT_CPPFLAGS}}} have
 been used, but those would need to be updated to use the does-not-yet-
 exist {{{MACPORTS_LEGACY_SUPPORT_CXXFLAGS}}}.


 This error:
 {{{
 Undefined symbols for architecture x86_64:
   "___cxa_thread_atexit", referenced from:
 }}}

 indicates that the library containing that symbol has not been linked in.
 That symbol is in libc++abi.dylib on 10.6 (it's a special addition to
 support thread_local for 10.6 and less), and is supposed to be re-exported
 by libc++.dylib. One would have to examine the link line to see what is
 going wrong with that link.

-- 
Ticket URL: <https://trac.macports.org/ticket/67446#comment:9>
MacPorts <https://www.macports.org/>
Ports system for macOS