[MacPorts] #67266: poppler: patch-poppler-gcc7-noexcept.diff fails to apply

MacPorts noreply at macports.org
Wed Feb 7 19:53:34 UTC 2024


#67266: poppler: patch-poppler-gcc7-noexcept.diff fails to apply
---------------------------+----------------------
  Reporter:  barracuda156  |      Owner:  dbevans
      Type:  defect        |     Status:  assigned
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:  2.8.1
Resolution:                |   Keywords:
      Port:  poppler       |
---------------------------+----------------------

Comment (by barracuda156):

 Replying to [comment:11 ballapete]:
 > The sources have partly changed, the kind of second half in `patch-
 poppler-gcc7-noexcept.diff` can be removed:
 >
 > {{{
 >      34 --- poppler/CertificateInfo.cc.orig
 >      35 +++ poppler/CertificateInfo.cc
 >      36 @@ -39,7 +39,7 @@
 >      37
 >      38
 X509CertificateInfo::EntityInfo::EntityInfo(X509CertificateInfo::EntityInfo
 &&other) noexcept = default;
 >      39
 >      40 -X509CertificateInfo::EntityInfo
 &X509CertificateInfo::EntityInfo::operator=(X509CertificateInfo::EntityInfo
 &&other) noexcept = default;
 >      41 +X509CertificateInfo::EntityInfo
 &X509CertificateInfo::EntityInfo::operator=(X509CertificateInfo::EntityInfo
 &&other) = default;
 >      42
 >      43  X509CertificateInfo::X509CertificateInfo() :
 ku_extensions(KU_NONE), cert_version(-1), is_self_signed(false) { }
 >      44
 >      45 --- poppler/CertificateInfo.h.orig
 >      46 +++ poppler/CertificateInfo.h
 >      47 @@ -70,7 +70,7 @@
 >      48          ~EntityInfo();
 >      49
 >      50          EntityInfo(EntityInfo &&) noexcept;
 >      51 -        EntityInfo &operator=(EntityInfo &&) noexcept;
 >      52 +        EntityInfo &operator=(EntityInfo &&);
 >      53
 >      54          EntityInfo(const EntityInfo &) = delete;
 >      55          EntityInfo &operator=(const EntityInfo &) = delete;
 > }}}
 >
 > There does not seem to exist any code that resembles that cited above
 (but I have no idea of C++…)

 If you confirm it builds with gcc7 then, please submit a PR with the fix.

-- 
Ticket URL: <https://trac.macports.org/ticket/67266#comment:12>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list