[MacPorts] #69380: libffi fails on 10.5 PPC for bad patch

[MacPorts]

#69380: libffi fails on 10.5 PPC for bad patch
-----------------------+-------------------------
  Reporter:  rmottola  |      Owner:  (none)
      Type:  defect    |     Status:  new
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:
Resolution:            |   Keywords:  leopard ppc
      Port:  libffi    |
-----------------------+-------------------------

Comment (by ballapete):

 Replying to [comment:18 fhgwright]:
 > Replying to [comment:3 rmottola]:
 > > Being the patch for intel only, I removed it as a test from the
 portfile and it compiled on PPC.
 >
 > In general, conditionally-applied patches are a bad idea.  If at all
 possible, any conditional behavior of patches should be ''within'' the
 patches, not in whether to apply them.  The idea is to create a single set
 of modified sources that works in all cases.  Ideally, this should even
 mean being acceptable for non-Mac systems, with the goal of being
 acceptable as upstream changes (whether or not upstream actually accepts
 them).
 >
 I stick to my limitations. As with Wikipedia, I appreciate every
 improvement of my articles. Or patches…

-- 
Ticket URL: <https://trac.macports.org/ticket/69380#comment:19>
MacPorts <https://www.macports.org/>
Ports system for macOS