[MacPorts] #69079: rocksdb: test_util/mock_time_env.h:72:16: error: 'TimedWait' marked 'override' but does not override any member functions; test_util/secondary_cache_test_util.cc:41:23: error: unknown type name 'CacheTier'

[MacPorts]

#69079: rocksdb: test_util/mock_time_env.h:72:16: error: 'TimedWait' marked
'override' but does not override any member functions;
test_util/secondary_cache_test_util.cc:41:23: error: unknown type name
'CacheTier'
------------------------+----------------------
 Reporter:  neverpanic  |      Owner:  stromnov
     Type:  defect      |     Status:  assigned
 Priority:  Normal      |  Milestone:
Component:  ports       |    Version:
 Keywords:              |       Port:  rocksdb
------------------------+----------------------
 rocksdb 8.9.1 fails to build on macOS 14.2.1 23C71 arm64 with Xcode 15.2
 15C500b. {{clang -v}} is

 {{{
 $ clang -v
 Apple clang version 15.0.0 (clang-1500.1.0.2.5)
 Target: arm64-apple-darwin23.2.0
 Thread model: posix
 InstalledDir:
 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
 }}}

 I see two errors in the main.log:

 {{{
 :info:build /usr/bin/clang++ -DBZIP2 -DGFLAGS=1 -DHAVE_FULLFSYNC -DLZ4
 -DOS_MACOSX -DROCKSDB_LIB_IO_POSIX -DROCKSDB_NO_DYNAMIC_EXTENSION
 -DROCKSDB_PLATFORM_POSIX -DSNAPPY -DZLIB -DZSTD -I/opt/local/include
 -I/opt/local/var/macports/build/_opt_dports_databases_rocksdb/rocksdb/work/rocksdb-8.9.1
 -I/opt/local/var/macports/build/_opt_dports_databases_rocksdb/rocksdb/work/rocksdb-8.9.1/include
 -isystem
 /opt/local/var/macports/build/_opt_dports_databases_rocksdb/rocksdb/work/rocksdb-8.9.1
 /third-party/gtest-1.8.1/fused-src -pipe -Os -DNDEBUG -I/opt/local/include
 -stdlib=libc++
 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -W -Wextra
 -Wall -pthread -Wsign-compare -Wshadow -Wno-unused-parameter -Wno-unused-
 variable -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-
 initializers -Wno-strict-aliasing -Wno-invalid-offsetof -fno-omit-frame-
 pointer -momit-leaf-frame-pointer -march=armv8-a+crc+crypto -Wno-unused-
 function -Werror -arch arm64 -isysroot
 /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -mmacosx-version-
 min=14.0 -std=gnu++17 -MD -MT
 CMakeFiles/testharness.dir/test_util/mock_time_env.cc.o -MF
 CMakeFiles/testharness.dir/test_util/mock_time_env.cc.o.d -o
 CMakeFiles/testharness.dir/test_util/mock_time_env.cc.o -c
 /opt/local/var/macports/build/_opt_dports_databases_rocksdb/rocksdb/work/rocksdb-8.9.1/test_util/mock_time_env.cc
 […]
 :info:build In file included from
 /opt/local/var/macports/build/_opt_dports_databases_rocksdb/rocksdb/work/rocksdb-8.9.1/test_util/mock_time_env.cc:6:
 :info:build
 /opt/local/var/macports/build/_opt_dports_databases_rocksdb/rocksdb/work/rocksdb-8.9.1/test_util/mock_time_env.h:72:16:
 error: 'TimedWait' marked 'override' but does not override any member
 functions
 :info:build   virtual bool TimedWait(port::CondVar* cv,
 :info:build                ^
 :info:build 1 error generated.
 :info:build make[2]: ***
 [CMakeFiles/testharness.dir/test_util/mock_time_env.cc.o] Error 1
 }}}

 and

 {{{
 :info:build /usr/bin/clang++ -DBZIP2 -DGFLAGS=1 -DHAVE_FULLFSYNC -DLZ4
 -DOS_MACOSX -DROCKSDB_LIB_IO_POSIX -DROCKSDB_NO_DYNAMIC_EXTENSION
 -DROCKSDB_PLATFORM_POSIX -DSNAPPY -DZLIB -DZSTD -I/opt/local/include
 -I/opt/local/var/macports/build/_opt_dports_databases_rocksdb/rocksdb/work/rocksdb-8.9.1
 -I/opt/local/var/macports/build/_opt_dports_databases_rocksdb/rocksdb/work/rocksdb-8.9.1/include
 -isystem
 /opt/local/var/macports/build/_opt_dports_databases_rocksdb/rocksdb/work/rocksdb-8.9.1
 /third-party/gtest-1.8.1/fused-src -pipe -Os -DNDEBUG -I/opt/local/include
 -stdlib=libc++
 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -W -Wextra
 -Wall -pthread -Wsign-compare -Wshadow -Wno-unused-parameter -Wno-unused-
 variable -Woverloaded-virtual -Wnon-virtual-dtor -Wno-missing-field-
 initializers -Wno-strict-aliasing -Wno-invalid-offsetof -fno-omit-frame-
 pointer -momit-leaf-frame-pointer -march=armv8-a+crc+crypto -Wno-unused-
 function -Werror -arch arm64 -isysroot
 /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk -mmacosx-version-
 min=14.0 -std=gnu++17 -MD -MT
 CMakeFiles/testharness.dir/test_util/secondary_cache_test_util.cc.o -MF
 CMakeFiles/testharness.dir/test_util/secondary_cache_test_util.cc.o.d -o
 CMakeFiles/testharness.dir/test_util/secondary_cache_test_util.cc.o -c
 /opt/local/var/macports/build/_opt_dports_databases_rocksdb/rocksdb/work/rocksdb-8.9.1/test_util/secondary_cache_test_util.cc
 […]
 :info:build
 /opt/local/var/macports/build/_opt_dports_databases_rocksdb/rocksdb/work/rocksdb-8.9.1/test_util/secondary_cache_test_util.cc:41:23:
 error: unknown type name 'CacheTier'
 :info:build                       CacheTier /*source*/,
 Cache::CreateContext* context,
 :info:build                       ^
 :info:build make[2]: ***
 [CMakeFiles/testharness.dir/test_util/secondary_cache_test_util.cc.o]
 Error 1
 }}}

 Since those both seem to occur in testing code, maybe we can disable
 building the tests?

-- 
Ticket URL: <https://trac.macports.org/ticket/69079>
MacPorts <https://www.macports.org/>
Ports system for macOS