[MacPorts] #70253: opendx port fails with implicit int error in C99

[MacPorts]

#70253: opendx port fails with implicit int error in C99
------------------------+--------------------
  Reporter:  bernstei   |      Owner:  (none)
      Type:  defect     |     Status:  closed
  Priority:  Normal     |  Milestone:
 Component:  ports      |    Version:
Resolution:  duplicate  |   Keywords:
      Port:  opendx     |
------------------------+--------------------

Comment (by bernstei):

 So, I know this ticket is closed as being a duplicate of 61842, but it is
 not.  Can it be reopened?  61842 involves source autogenerated by
 lexx/yacc/bison, and I don't think is feasible to fix.  This one involves
 static source in opendx itself, and may be fixable.

 I've been looking more carefully, and I've fixed a number of issues, but I
 can tell you that it's just a mess. For example, it's giving
 c++11-narrowing errors because of trying to put values > 128 into a char
 array. It's easy to fix that problem by making it unsigned char, but then
 there's an error passing it to the relevant X function
 (XCreatePixmapFromBitmapData in this case), so they have to be cast back
 to (char *).  Anyway, it's manageable so far, but I'd just like to point
 out that this is a very large and _old_ port, that has many assumptions,
 now outdated, about how compilers behave.

 I think it's quite likely that it's much more sustainable to set the
 compilers to behave like their older versions, which the opendx developers
 assumed, than to update opendx to modern standards.  Certainly the
 resulting patch for this ticket is much smaller that way.

-- 
Ticket URL: <https://trac.macports.org/ticket/70253#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS