[MacPorts] #69782: legacy-support: Minor issues with ARCHFLAGS in the Makefile

[MacPorts]

#69782: legacy-support: Minor issues with ARCHFLAGS in the Makefile
-----------------------------+---------------------
  Reporter:  TurtleWilly     |      Owner:  mascguy
      Type:  enhancement     |     Status:  closed
  Priority:  Normal          |  Milestone:
 Component:  ports           |    Version:
Resolution:  fixed           |   Keywords:
      Port:  legacy-support  |
-----------------------------+---------------------
Changes (by fhgwright):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"86a71bfc238cda8577a8abc4f16a1b6e010d7492/macports-legacy-
 support" 86a71bfc238cda8577a8abc4f16a1b6e010d7492/macports-legacy-support]
 (master):
 {{{
 #!ConfigurableCommitTicketReference repository="macports-legacy-support"
 revision="86a71bfc238cda8577a8abc4f16a1b6e010d7492"
 Makefile: Fix CC/CXX/LD flags issues.

 This fixes three issues with specifying flag variables to the Makefile:

 1) It attempted to insert ARCHFLAGS into CC and CXX, but it was using ?=,
 which doesn't work for predefined variables.

 2) It never incorporated ARCHFLAGS into LDFLAGS.

 3) It provided some defaults in CFLAGS and CXXFLAGS, but any setting of
 these variables removed those defaults.  The defaults are now in XCFLAGS
 and XCXXFLAGS, which are added to C[XX]FLAGS, along with ARCHFLAGS, so
 they normally are kept.  If removing the defaults is desired, then
 XC[XX]FLAGS can be overridden.

 Note that the port build procedure uses FORCE_ARCH, not ARCHFLAGS.

 Closes: https://trac.macports.org/ticket/69782

 TESTED:
 ARCHFLAGS is now respected, and setting CFLAGS doesn't remove
 defaults.
 }}}

-- 
Ticket URL: <https://trac.macports.org/ticket/69782#comment:8>
MacPorts <https://www.macports.org/>
Ports system for macOS