[MacPorts] #69380: libffi fails on 10.5 PPC for bad patch

[MacPorts]

#69380: libffi fails on 10.5 PPC for bad patch
-----------------------+-------------------------
  Reporter:  rmottola  |      Owner:  (none)
      Type:  defect    |     Status:  new
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:
Resolution:            |   Keywords:  leopard ppc
      Port:  libffi    |
-----------------------+-------------------------

Comment (by fhgwright):

 Replying to [comment:23 ballapete]:
 > Replying to [comment:22 fhgwright]:
 > > Replying to [comment:21 ballapete]:
 > >
 > > Actually, back when I was wrestling with `libffi` issues, I found that
 the most troublesome architecture was `i386`.  This may be because it's
 the most register-starved architecture, and hence the one with the
 kludgiest ABI.
 > >
 > With my first answer sentence I wanted to express that G4 and G5 can
 handle both sorts of data MSB, as coming from earlier Motorola processors,
 and LSB, as used in the i386/x86 world. This could lead to more tests for
 PPC.

 While it's true that PPC processors have cross-endian loads and stores,
 that's completely irrelevant in this context, since there's nothing cross-
 endian about `libffi`.

 > Another case is that G4 is some kind of "64 bit aware" while G5 is 64
 bit.

 I don't know what you mean by "64-bit aware".  The G4 is a pure 32-bit
 processor, just like `i386` (or 32-bit `arm`, for that matter).  While the
 C language has supported 64-bit operations on 32-bit processors since C99,
 that's done by generating double-precision machine code, not by any
 "64-bit awareness" of the CPU (beyond support for multiprecision
 operations in general, which pretty much all CPUs have).

 > I am not sure whether Riccardo cites "64bit" correctly for his test
 results. Is his intel CPU 64 bit? If not then 64 bit tests are useless and
 would not be run, decreasing the number of tests performed. On my modern
 MacBook the number of tests is also quite low, which might indicate that
 this family of intel processors has less things to test.

 AFAIK, `libffi` has no "64-bit tests" specifically, but just runs the
 tests on whatever architecture it's built for.  In universal builds, the
 tests are run on each architecture separately (for all built architectures
 that are executable on the host).

 > But actually I have no idea of what the tests are!

 Use the source, Luke! :-)

-- 
Ticket URL: <https://trac.macports.org/ticket/69380#comment:27>
MacPorts <https://www.macports.org/>
Ports system for macOS