[MacPorts] #69428: mariadb*: fails to build with libxml2 2.12.x

[MacPorts]

#69428: mariadb*: fails to build with libxml2 2.12.x
-------------------------------------------------+-------------------------
  Reporter:  amstilp                             |      Owner:  michaelld
      Type:  defect                              |     Status:  assigned
  Priority:  Normal                              |  Milestone:
 Component:  ports                               |    Version:
Resolution:                                      |   Keywords:
      Port:  mariadb mariadb-10.0 mariadb-10.1   |
  mariadb-10.2 mariadb-10.3 mariadb-10.4         |
  mariadb-10.5 mariadb-10.6 mariadb-10.7         |
  mariadb-10.8 mariadb-10.9 mariadb-10.10        |
  mariadb-10.11                                  |
-------------------------------------------------+-------------------------

Comment (by blair):

 Looking at the previous libxml2 `2.11.5` the `--with-legacy` configure
 flag already existed, so I'm guessing it wouldn't help in the `2.12.5`
 upgrade. Doing a recursive diff between `2.11.5` and `2.12.5` doesn't show
 any additional places where `LIBXML_LEGACY_ENABLED` is used, although
 there could be new code added between an `#ifdef LIBXML_LEGACY_ENABLED`
 and `#endif` pair (I didn't check).

 In `include/libxml/xmlerror.h` the diff is this and it's not protected by
 `LIBXML_LEGACY_ENABLED` so it seems all callbacks will need to do a patch
 similar to `webkit2-gtk `'s in https://github.com/macports/macports-
 ports/commit/915fbf4e3d488321c05f7ff2123282979bb9af46

 ```
 @@ -855,7 +856,28 @@
   * Signature of the function to use when there is an error and
   * the module handles the new error reporting mechanism.
   */
 -typedef void (*xmlStructuredErrorFunc) (void *userData, xmlErrorPtr
 error);
 +typedef void (*xmlStructuredErrorFunc) (void *userData, const xmlError
 *error);
 +
 ```

 There's this upstream bug https://github.com/MariaDB/server/pull/2983 and
 PR: https://github.com/MariaDB/server/pull/2983 would could be pulled into
 MacPorts.

-- 
Ticket URL: <https://trac.macports.org/ticket/69428#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS