[MacPorts] #67266: poppler: patch-poppler-gcc7-noexcept.diff fails to apply

[MacPorts]

#67266: poppler: patch-poppler-gcc7-noexcept.diff fails to apply
---------------------------+----------------------
  Reporter:  barracuda156  |      Owner:  dbevans
      Type:  defect        |     Status:  assigned
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:  2.8.1
Resolution:                |   Keywords:
      Port:  poppler       |
---------------------------+----------------------

Comment (by ballapete):

 `poppler-24.03.0` fails to find `gpgme`

 {{{
 CMake Warning at CMakeLists.txt:160 (find_package):
   By not providing "FindGpgme.cmake" in CMAKE_MODULE_PATH this project has
   asked CMake to find a package configuration file provided by "Gpgme",
 but
   CMake did not find one.

   Could not find a package configuration file provided by "Gpgme"
 (requested
   version 1.19) with any of the following names:

     GpgmeConfig.cmake
     gpgme-config.cmake

   Add the installation prefix of "Gpgme" to CMAKE_PREFIX_PATH or set
   "Gpgme_DIR" to a directory containing one of the above files.  If
 "Gpgme"
   provides a separate development package or SDK, be sure it has been
   installed.
 Call Stack (most recent call first):
   CMakeLists.txt:168 (find_soft_mandatory_package)


 CMake Error at CMakeLists.txt:162 (MESSAGE):
   Could not find the 1.19 version of Gpgme.  If you're not interested in
 the
   features it provides set the cmake ENABLE_GPGME option to OFF
 Call Stack (most recent call first):
   CMakeLists.txt:168 (find_soft_mandatory_package)


 -- Configuring incomplete, errors occurred!
 }}}

 because `CMakeLists.txt` has on #169?

 {{{
 find_soft_mandatory_package(ENABLE_GPGME Gpgmepp 1.19)
 }}}

 I do have a suitable version of `gpgme` installed:

 {{{
   gpgme @1.20.0_0 (active) requested_variants='' platform='darwin 8'
 archs='ppc' date='2023-05-25T00:50:02+0200'
 }}}

 so line #82 might become?

 {{{
 option(ENABLE_GPGME "Build the GPG backend for cryptographic support" OFF)
 }}}

 Because `gpgme` might be different from `Gpgmepp` – is the latter
 `MacPorts' gpgme-objc @1.0.2_6`? Most important is line #169 that sets
 `Gpgmepp` as **mandatory**. And since it's not found, compilation ends
 here. OTOH the `ENABLE_GPGME` ''macro'' is used more than once in
 `CMakeLists.txt` – maybe it just tells to try use `GnuPG` if found?

 When line #169 is removed and line #82 is left unchanged the build process
 ends here:

 {{{
 [  8%] Building CXX object CMakeFiles/poppler.dir/fofi/FoFiType1.cc.o
 /opt/local/bin/g++-mp-7 -Dpoppler_EXPORTS
 -I/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_graphics_poppler/poppler/work/poppler-24.03.0
 -I/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_graphics_poppler/poppler/work/poppler-24.03.0/fofi
 -I/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_graphics_poppler/poppler/work/poppler-24.03.0/goo
 -I/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_graphics_poppler/poppler/work/poppler-24.03.0/poppler
 -I/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_graphics_poppler/poppler/work/build
 -I/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_graphics_poppler/poppler/work/build/poppler
 -isystem /opt/local/include/openjpeg-2.5 -isystem /opt/local/include
 -isystem /opt/local/include/freetype2 -isystem /usr/X11/include -isystem
 /opt/local/include/nss -isystem /opt/local/include/nspr -isystem
 /opt/local/libexec/boost/1.76/include -Wall -Wextra -Wpedantic -Wno-
 unused-parameter -Wcast-align -Wformat-security -Wframe-larger-than=65536
 -Wlogical-op -Wmissing-format-attribute -Wnon-virtual-dtor -Woverloaded-
 virtual -Wmissing-declarations -Wundef -Wzero-as-null-pointer-constant
 -Wshadow -Wsuggest-override -fno-exceptions -fno-check-new -fno-common
 -fno-operator-names -D_DEFAULT_SOURCE -O2 -g -pipe
 -I/opt/local/libexec/boost/1.76/include -Os -DNDEBUG
 -I/opt/local/libexec/boost/1.76/include
 -isystem/opt/local/include/LegacySupport -D_GLIBCXX_USE_CXX11_ABI=0 -arch
 ppc -mmacosx-version-min=10.4 -fPIC -fvisibility=hidden -fvisibility-
 inlines-hidden -std=c++1z -MD -MT
 CMakeFiles/poppler.dir/fofi/FoFiType1.cc.o -MF
 CMakeFiles/poppler.dir/fofi/FoFiType1.cc.o.d -o
 CMakeFiles/poppler.dir/fofi/FoFiType1.cc.o -c
 /opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_graphics_poppler/poppler/work/poppler-24.03.0/fofi/FoFiType1.cc
 /opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_graphics_poppler/poppler/work/poppler-24.03.0/fofi/FoFiType1.cc:31:10:
 fatal error: charconv: No such file or directory
  #include <charconv>
           ^~~~~~~~~~
 compilation terminated.
 gmake[2]: *** [CMakeFiles/poppler.dir/build.make:331:
 CMakeFiles/poppler.dir/fofi/FoFiType1.cc.o] Error 1
 gmake[2]: Leaving directory
 '/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_graphics_poppler/poppler/work/build'
 gmake[1]: *** [CMakeFiles/Makefile2:202: CMakeFiles/poppler.dir/all] Error
 2
 gmake[1]: Leaving directory
 '/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_graphics_poppler/poppler/work/build'
 gmake: *** [Makefile:149: all] Error 2
 gmake: Leaving directory
 '/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_graphics_poppler/poppler/work/build'
 }}}

 This `C++ charconv` file can be found on newer macOS versions (`Sonoma`),
 it seems that also up-to-date versions of `GCC` (13) or `Clang` provide
 it.

-- 
Ticket URL: <https://trac.macports.org/ticket/67266#comment:21>
MacPorts <https://www.macports.org/>
Ports system for macOS