[MacPorts] #61696: transcode @1.1.7: error: implicit declaration of function 'audio_resample_close' is invalid in C99

[MacPorts]

#61696: transcode @1.1.7: error: implicit declaration of function
'audio_resample_close' is invalid in C99
-------------------------+-------------------------------------------------
  Reporter:  mf2k        |      Owner:  Liontooth
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:
Resolution:              |   Keywords:  catalina bigsur monterey ventura
      Port:  transcode   |  sonoma
-------------------------+-------------------------------------------------

Comment (by ryandesign):

 I was looking into this too but what I found was that the ffmpeg audio
 resample API being used here was deprecated in 2013 and
 [https://github.com/FFmpeg/FFmpeg/commit/8f483108b503fa03ed5e956e25df4cb899171df5
 removed from ffmpeg in 2017 in version 4.0]. I would imagine that any
 attempt to by transcode to actually call these functions will cause a
 runtime crash since the functions do not exist anymore. The function call
 is in filter_resample.so. I gather this filter has to do with changing the
 sample rate of audio. I wanted to try to provoke that crash by using
 transcode to convert a video and change its sample rate, but I couldn't
 even figure out how to convert a video at all.

 If you can get it to work, and it doesn't crash, and we want to keep
 ffmpeg support, then we might add this patch from arch linux that we
 haven't yet copied (I added it to my copy of the port already before
 realizing the above):

 https://gitlab.archlinux.org/archlinux/packaging/packages/transcode/-/blob/36df429f94b00b8b209dcd7bd2303c255ebdd225
 /transcode-swresample.patch

 However if this filter crashes, we should remove it. And if we can't
 figure out how to convert any video with transcode and ffmpeg, then we
 could disable the ffmpeg support like some Linux distributions have
 (despite the statement in the README that ffmpeg is not optional). They
 said the code being used here was removed in ffmpeg 5.0. We could also
 delete the port (and the three ports that depend on it) entirely, as you
 suggested above and as the other Linux distributions (those that haven't
 just disabled its ffmpeg support) have done.

-- 
Ticket URL: <https://trac.macports.org/ticket/61696#comment:9>
MacPorts <https://www.macports.org/>
Ports system for macOS