[MacPorts] #70997: Warning: Unnecessary platforms line as darwin is the default

MacPorts noreply at macports.org
Sat Nov 23 07:02:40 UTC 2024


#70997: Warning: Unnecessary platforms line as darwin is the default
-------------------------+--------------------
  Reporter:  ryandesign  |      Owner:  (none)
      Type:  defect      |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  base        |    Version:  2.10.1
Resolution:              |   Keywords:
      Port:              |
-------------------------+--------------------

Comment (by pguyot):

 Replying to [comment:2 Dave-Allured]:
 > This warning was added to base a few months ago.  I think it is
 unnecessary and makes extra work and confusion.  It also is contradictory
 to the guidelines in the [https://guide.macports.org/#development
 .creating-portfile port development chapter] of the Macports guide.
 >
 > It is fine to have a default of "platforms darwin", and to not require
 it for new work.  However, that is no reason to purge the platform line in
 existing ports, just because it was made into a default.
 >
 > Here is a [https://github.com/macports/macports-base/pull/358 PR to
 simply remove the warning].  This reverts a small part of the
 [changeset:5297f1cebe34b6e635fee0aeed507e54330fbe25/macports-base original
 commit, several months ago].
 >
 > What do others think?  @pguyot?

 I only implemented in lint a remark I've seen repeatedly in reviews. It
 seems that the consensus now is that the platforms line should not be
 present if its value is the default, as it's the case for many other
 options. The documentation probably should be updated.

 This bug is about the false positive with subports, which I am solving
 with PR359 https://github.com/macports/macports-base/pull/359

 We probably want lint to lint every subports, but this would be another
 PR.

-- 
Ticket URL: <https://trac.macports.org/ticket/70997#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list