[MacPorts] #71162: xar @1.8.0.501_0: error: implicit declaration of function 'xar_prop_get_expect_notnull' is invalid in C99 [-Werror, -Wimplicit-function-declaration]

[MacPorts]

#71162: xar @1.8.0.501_0: error: implicit declaration of function
'xar_prop_get_expect_notnull' is invalid in C99 [-Werror,-Wimplicit-
function-declaration]
-------------------------+-------------------------
  Reporter:  ryandesign  |      Owner:  Schamschula
      Type:  defect      |     Status:  assigned
  Priority:  High        |  Milestone:
 Component:  ports       |    Version:  2.10.2
Resolution:              |   Keywords:  monterey
      Port:  xar         |
-------------------------+-------------------------

Comment (by ryandesign):

 Replying to [comment:1 Schamschula]:
 > However, when I rolled back the failing builds to the previous version,
 the build bot insisted in attempting to build the incorrect version of
 xar.
 >
 > I don't see the logic error in the Portfile.

 I'm not sure what you mean. The port versions seem to be what they should
 be based on the portfile code:

 {{{
 % for osmajor in $(seq 8 24); do printf %2d: $osmajor; port info --version
 xar os.major=$osmajor; done
  8:version: 1.8.0.498
  9:version: 1.8.0.498
 10:version: 1.8.0.498
 11:version: 1.8.0.498
 12:version: 1.8.0.498
 13:version: 1.8.0.498
 14:version: 1.8.0.501
 15:version: 1.8.0.501
 16:version: 1.8.0.501
 17:version: 1.8.0.501
 18:version: 1.8.0.501
 19:version: 1.8.0.501
 20:version: 1.8.0.501
 21:version: 1.8.0.501
 22:version: 1.8.0.501
 23:version: 1.8.0.501
 24:version: 1.8.0.501
 }}}

 Buildbot is building xar 501 on macOS 11 and 12 like you're telling it to.
 Buildbot is not special; the same thing that happens on Buildbot workers
 happens on user systems as well.

 > These two OS versions need their own patch file anyway, as there are
 different implicit function definitions that are missing.

 I haven't yet dug into their code but do you know why this differs by OS
 version?

 > The problem is that I have no way of testing on anything older than
 macOS Sonoma.

 It is possible to set up virtual machines running older macOS versions,
 though that of course takes time and disk space to set up and I wouldn't
 expect anyone to do that.

-- 
Ticket URL: <https://trac.macports.org/ticket/71162#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS