[MacPorts] #71162: xar @1.8.0.501_0: error: implicit declaration of function 'xar_prop_get_expect_notnull' is invalid in C99 [-Werror, -Wimplicit-function-declaration]

[MacPorts]

#71162: xar @1.8.0.501_0: error: implicit declaration of function
'xar_prop_get_expect_notnull' is invalid in C99 [-Werror,-Wimplicit-
function-declaration]
-------------------------+------------------------------
  Reporter:  ryandesign  |      Owner:  Schamschula
      Type:  defect      |     Status:  assigned
  Priority:  High        |  Milestone:
 Component:  ports       |    Version:  2.10.2
Resolution:              |   Keywords:  bigsur, monterey
      Port:  xar         |
-------------------------+------------------------------

Comment (by ryandesign):

 Regardless whether I define `XARSIG_BUILDING_WITH_XAR` or reinstate the
 part of the patch of xar_internal.h that you removed in
 [changeset:f25b28b7a0911f100870d702b258a2911341fe82/macports-ports the 501
 update], I get this error on macOS 12:

 {{{
 lib/archive.h:45:10: fatal error: 'CommonCrypto/CommonDigestSPI.h' file
 not found
 #include <CommonCrypto/CommonDigestSPI.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1 error generated.
 }}}

 I don't have such a header in
 /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/CommonCrypto
 on macOS 12 but I don't see it on a macOS 15 machine either. I see a hint
 in webkit source code that this is an Apple internal header, so we can't
 use it.

 Wherever this header is included, it is only when `__APPLE__` is defined.
 There is a fallback to openssl for other systems. Maybe we need to take
 that fallback in MacPorts too.

 Attaching my work in progress.

-- 
Ticket URL: <https://trac.macports.org/ticket/71162#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS