[MacPorts] #71162: xar @1.8.0.501_0: error: implicit declaration of function 'xar_prop_get_expect_notnull' is invalid in C99 [-Werror, -Wimplicit-function-declaration]

[MacPorts]

#71162: xar @1.8.0.501_0: error: implicit declaration of function
'xar_prop_get_expect_notnull' is invalid in C99 [-Werror,-Wimplicit-
function-declaration]
-------------------------+------------------------------
  Reporter:  ryandesign  |      Owner:  Schamschula
      Type:  defect      |     Status:  assigned
  Priority:  High        |  Milestone:
 Component:  ports       |    Version:  2.10.2
Resolution:              |   Keywords:  bigsur, monterey
      Port:  xar         |
-------------------------+------------------------------

Comment (by ryandesign):

 Replying to [comment:6 Schamschula]:
 > Note: for version 501 {{{xar_internal.h}}} has a line
 >
 > {{{xar_t xar_fdopen_digest_verify(int fd, int32_t flags, void
 *expected_toc_digest, size_t expected_toc_digest_len)
 API_AVAILABLE(macos(15.0));}}}
 >
 > Does that not mean that this is only available with the macOS 15 API,
 i.e. Xcode 16.x?

 I'm not really familiar with this. I have read
 [https://developer.apple.com/documentation/swift/marking-api-availability-
 in-objective-c Marking API Availability in Objective-C]. I think it means
 that `xar_fdopen_digest_verify` can only be used when the deployment
 target is 15.0 or later. xar doesn't ever call `xar_fdopen_digest_verify`.
 It appears to be just a library function that will be in libxar for others
 to use if they want. And if they did want to use it, they would have to do
 so only when the deployment target is 15.0 or later. I'm not sure if one
 should be able to build this library when the deployment target is less
 than 15.0.

 But that seems orthogonal to the point that the xar build is using the
 system xar.h header rather than the one that ships with xar because you
 removed the fix for #64842.

-- 
Ticket URL: <https://trac.macports.org/ticket/71162#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS