[MacPorts] #72395: golang portgroup: destroot fails by default and makes using default destroot phase commands impossible

[MacPorts]

#72395: golang portgroup: destroot fails by default and makes using default
destroot phase commands impossible
-----------------------+--------------------
 Reporter:  exprez135  |      Owner:  (none)
     Type:  defect     |     Status:  new
 Priority:  Normal     |  Milestone:
Component:  ports      |    Version:
 Keywords:  portgroup  |       Port:
-----------------------+--------------------
 The golang portgroup currently sets the destroot to {}, and also causes an
 error if the user has not otherwise set the destroot phase.

 This seems to assume that packages configured with the portgroup don't
 have proper Makefiles that should be used with `make install
 DESTDIR=${destroot}`. The error messages give guidance in the case that
 users are just relying on the default golang build.cmd.

 Relevant code: https://github.com/macports/macports-
 ports/blob/5e2f31f772e5fd63023c7dd093a3152425d5b12a/_resources/port1.0/group/golang-1.0.tcl#L443

 @jmr suggested on IRC that since this seems to really just be for guidance
 purposes, it should be a pre-destroot block and only error if the default
 destroot really does not work.

-- 
Ticket URL: <https://trac.macports.org/ticket/72395>
MacPorts <https://www.macports.org/>
Ports system for macOS