[MacPorts] #72021: sqlite3 @3.49.0: wrong install name for libsqlite3.dylib

[MacPorts]

#72021: sqlite3 @3.49.0: wrong install name for libsqlite3.dylib
-------------------------+------------------------
  Reporter:  ryandesign  |      Owner:  ryandesign
      Type:  defect      |     Status:  closed
  Priority:  High        |  Milestone:
 Component:  ports       |    Version:  2.10.5
Resolution:  fixed       |   Keywords:
      Port:  sqlite3     |
-------------------------+------------------------

Comment (by ryandesign):

 You're now setting the install name to /opt/local/lib/libsqlite3.dylib
 whereas before it was /opt/local/lib/libsqlite3.0.dylib. Both will work
 since both paths exist (as symlinks to the real library) however it seems
 like an unnecessary change. Shall we switch it back to the value it was
 using previously?

 You're fixing the install name in post-destroot. Seems like post-build
 would be the more logical place.

 You're manually inserting quotation marks around a path in the `system`
 call, which has the effect of handling some special characters within the
 variable value correctly (like spaces) while not handling other special
 characters correctly (like quotation marks). While neither values are
 likely to appear within the prefix variable, if we're going to escape,
 let's do it completely correctly. The `shellescape` procedure exists for
 this purpose.

-- 
Ticket URL: <https://trac.macports.org/ticket/72021#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS