Fwd: Re: macports libsndfile 1.0.28 Mac OS X 10.4.11 Tiger

[Jan Stary]

Hi Thomas,

https://github.com/erikd/libsndfile/pull/355

If you have a problem with libsndfile itself,
discuss this at the libsndfile mailing list.

If you have a problem specifically with the MacPort of lbsndfile,
discuss it on the macports-users mailing list.

	Jan


> >> I have an old PPC Mac stuck with OS X Tiger.
> >> libsdnfile-1.0.28 doesn't build
> >> The attached patch resolves the issue
> > can you please send a full script(1) of port -vs install libsndfile?
> > Both without and with your patch?
> >
> > Mine is below - builds fine on 10.5.8/intel.
> > (I don't think it's the intel vs ppc though.)
> I will send you the log.
> 
> However the build break with the error that Availability.h is not found,
> which is logical as this file was added to the Mac OS X SDK version 10.5
> 
> 
> >> --- libsndfile-1.0.28/programs/sndfile-play.c.orig	2018-01-26 23:13:33.000000000 +0100
> >> +++ libsndfile-1.0.28/programs/sndfile-play.c	2018-01-26 23:15:17.000000000 +0100
> >> @@ -61,7 +61,9 @@
> >>  
> >>  #elif (defined (__MACH__) && defined (__APPLE__))
> >>  	#include <AvailabilityMacros.h>
> >> -	#include <Availability.h>
> >> +	#if defined(MAC_OS_X_VERSION_10_5)
> >> +		#include <Availability.h>
> >> +	#endif
> >>  
> >>  #elif HAVE_SNDIO_H
> >>  	#include <sndio.h>
> > So 10.4.11 does not have Availability.h (right?). Can someone
> > comment on that please? (Maybe Apple started thinking iOS matters
> > around 10.5 time?)
> >
> > The patch doesn't seem right - if sndfile-play.c thinks
> > it needs to include Availabilty.h, it should include it if it exists,
> > not if defined(MAC_OS_X_VERSION_10_5). I can see it on 10.5.8 and 10.6.8
> > and 10.13.2 (I don't have other machines). Let me talk to upstream.
> the Availability.h was added by Apple for the __OSX_AVAILABLE_STARTING()
> macro
> 
> But I see sndfile-play.c never used it :
> https://github.com/erikd/libsndfile/commit/65a5067d7ac99ad4d296a7d67a8d07c589b59353
> 
> So I think including Availability.h was a mistake in the first place.
> (only AvailabilityMacros.h was required)
> And now that OS X support was completely removed, maybe removing both
> include is the best way to go
> Anyway the patch may be useful if they add OS X support again.
> 
> Regards,
> 
> Thomas