libiconv build fail w/macOS 14.4 (darwin/23.4.0) arch arm

[Paul Kippes]

Hi,

A recent OS update motivated the migration procedure of macports.  I'm
seeing a build error with libiconv (its one dependency installed
fine).

Prior working OS (captured from alt./separate system):

:debug:sysinfo macOS 14.3.1 (darwin/23.3.0) arch arm
:debug:sysinfo MacPorts 2.9.1
:debug:sysinfo Xcode 15.2, CLT 15.1.0.0.1.1700200546
:debug:sysinfo SDK 14
:debug:sysinfo MACOSX_DEPLOYMENT_TARGET: 14.0

Failing OS (differences only):

:debug:sysinfo macOS 14.4 (darwin/23.4.0) arch arm
:debug:sysinfo Xcode 15.3, CLT 15.3.0.0.1.1708646388

Comparing the build log of the alt. system to failing OS points to
this like that was a compiler warning and is now an error.  This
section of lib/encodings.def is part of the patched area.  I attempted
to add configure.cflags-append, providing
"-Wno-incompatible-function-pointer-types" without success.  First
time attempting to debug macports, so no doubt am wrong here.  Any
advice on how to proceed on adjusting Portfile patch or local OS issue
would be appreciated.  Thanks, --Paul

section of build log:

:info:build In file included from lib/genflags.c:109:
:info:build lib/encodings.def:75:45: error: incompatible function
pointer types initializing 'int (*)(conv_t, unsigned char *, ucs4_t,
size_t)' (aka 'int (*)(struct conv_struct *, unsigned char *, unsigned
int, unsigned long)') with an expression of type 'int (conv_t,
unsigned char *, ucs4_t, int)' (aka 'int (struct conv_struct *,
unsigned char *, unsigned int, int)')
[-Wincompatible-function-pointer-types]
:info:build             { utf8mac_mbtowc, NULL },     { utf8mac_wctomb, NULL })
:info:build                                             ^~~~~~~~~~~~~~
:info:build lib/genflags.c:104:34: note: expanded from macro 'DEFENCODING'
:info:build     struct wctomb_funcs ofuncs = xxx_ofuncs1,xxx_ofuncs2; \
:info:build                                  ^~~~~~~~~~~