[90624] trunk/dports/multimedia/MPlayer/Portfile

[ecronin at macports.org]

Revision: 90624
          http://trac.macports.org/changeset/90624
Author:   ecronin at macports.org
Date:     2012-03-09 20:59:34 -0800 (Fri, 09 Mar 2012)
Log Message:
-----------
MPlayer: clarify comments

Modified Paths:
--------------
    trunk/dports/multimedia/MPlayer/Portfile

Modified: trunk/dports/multimedia/MPlayer/Portfile
===================================================================
--- trunk/dports/multimedia/MPlayer/Portfile	2012-03-10 04:26:07 UTC (rev 90623)
+++ trunk/dports/multimedia/MPlayer/Portfile	2012-03-10 04:59:34 UTC (rev 90624)
@@ -88,7 +88,8 @@
 
 # MPlayer autodetects many support libs.  To prevent undeclared
 # dependencies, explicitly disable everything optional first.
-# Later, let autodetect do its magic not explicit --enable
+# This list should be expanded as new options are added to ./configure
+# each release.
 configure.args-append \
     --disable-smb --disable-live --disable-dvdnav \
     --disable-dvdread --disable-cdparanoia --disable-freetype \
@@ -119,6 +120,11 @@
     xinstall -m 0755 ${worksrcpath}/TOOLS/midentify.sh ${destroot}${prefix}/bin/midentify
 }
 
+# Re-enable the desired features in variants, along with listing the
+# necessary dependencies.  Warning: --enable-foo is not the same as
+# just letting autodetect work after removing --disable-foo...
+# Explicitly enabling features usually does not work right.
+
 ##### Mplayer features
 
 variant man_all_lang \
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macports-changes/attachments/20120309/010b71c0/attachment.html>