[90625] trunk/dports/multimedia

[ecronin at macports.org]

Revision: 90625
          http://trac.macports.org/changeset/90625
Author:   ecronin at macports.org
Date:     2012-03-09 21:14:42 -0800 (Fri, 09 Mar 2012)
Log Message:
-----------
MPlayer,mplayer-devel: clarify comments

Modified Paths:
--------------
    trunk/dports/multimedia/MPlayer/Portfile
    trunk/dports/multimedia/mplayer-devel/Portfile

Modified: trunk/dports/multimedia/MPlayer/Portfile
===================================================================
--- trunk/dports/multimedia/MPlayer/Portfile	2012-03-10 04:59:34 UTC (rev 90624)
+++ trunk/dports/multimedia/MPlayer/Portfile	2012-03-10 05:14:42 UTC (rev 90625)
@@ -88,8 +88,8 @@
 
 # MPlayer autodetects many support libs.  To prevent undeclared
 # dependencies, explicitly disable everything optional first.
-# This list should be expanded as new options are added to ./configure
-# each release.
+# This list should be expanded each time the port is updated to a
+# new version, disabling any newly added options.
 configure.args-append \
     --disable-smb --disable-live --disable-dvdnav \
     --disable-dvdread --disable-cdparanoia --disable-freetype \
@@ -120,10 +120,10 @@
     xinstall -m 0755 ${worksrcpath}/TOOLS/midentify.sh ${destroot}${prefix}/bin/midentify
 }
 
-# Re-enable the desired features in variants, along with listing the
-# necessary dependencies.  Warning: --enable-foo is not the same as
-# just letting autodetect work after removing --disable-foo...
-# Explicitly enabling features usually does not work right.
+# When adding back in extra features it usually works better to
+# just list the correct depends_lib and then let the auto-detect
+# code find the library versus using an explicit --enable-feature.
+# The later often ends up failing to find the headers or libs or both
 
 ##### Mplayer features
 

Modified: trunk/dports/multimedia/mplayer-devel/Portfile
===================================================================
--- trunk/dports/multimedia/mplayer-devel/Portfile	2012-03-10 04:59:34 UTC (rev 90624)
+++ trunk/dports/multimedia/mplayer-devel/Portfile	2012-03-10 05:14:42 UTC (rev 90625)
@@ -70,7 +70,8 @@
 
 # MPlayer autodetects many support libs.  To prevent undeclared
 # dependencies, explicitly disable everything optional first.
-# Later, let autodetect do its magic not explicit --enable
+# This list should be expanded each time the port is updated to a
+# new version, disabling any newly added options.
 configure.args-append \
     --disable-smb --disable-live --disable-dvdnav \
     --disable-dvdread --disable-cdparanoia --disable-freetype \
@@ -105,6 +106,11 @@
 
 universal_variant no
 
+# When adding back in extra features it usually works better to
+# just list the correct depends_lib and then let the auto-detect
+# code find the library versus using an explicit --enable-feature.
+# The later often ends up failing to find the headers or libs or both
+
 variant man_all_lang \
     description {Install all possible languages for man pages} {
     configure.args-append --language=all
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macports-changes/attachments/20120309/1fa67487/attachment.html>