[28065] trunk/dports/print/ghostscript/Portfile

[Ryan Schmidt]

On Aug 19, 2007, at 11:54, source_changes at macosforge.org wrote:

> Revision: 28065
>           http://trac.macosforge.org/projects/macports/changeset/28065
> Author:   digdog at macports.org
> Date:     2007-08-19 09:54:07 -0700 (Sun, 19 Aug 2007)
>
> Log Message:
> -----------
> 1. To prevent port upgrade failed
> 2. Add dependencies
> 3. Use another way to undo environment settings
>
> And, Thanks to Christian Cornelssen.
>
> Modified Paths:
> --------------
>     trunk/dports/print/ghostscript/Portfile
>
> Modified: trunk/dports/print/ghostscript/Portfile
> ===================================================================
> --- trunk/dports/print/ghostscript/Portfile	2007-08-19 16:53:39 UTC  
> (rev 28064)
> +++ trunk/dports/print/ghostscript/Portfile	2007-08-19 16:54:07 UTC  
> (rev 28065)
> @@ -24,13 +24,18 @@
>          ghostscript-fonts-std-8.11.tar.gz md5  
> 6865682b095f8c4500c54b285ff05ef6 \
>          ghostscript-fonts-other-6.0.tar.gz md5  
> 1a643ae62ef166562e4d422b1a601272
>
> -configure {
> -        # Ticket #11901
> -        # MacPorts 1.4.1 or higher adds -I${prefix}/include and -L$ 
> {prefix}/lib flags to the configure by default.
> -        # This change may break building ghostscript. Here is a  
> workaround to avoid this issue.
> -        system "cd $worksrcpath && ./configure --prefix=${prefix}"
> -}
> +depends_lib lib:libX11.6:XFree86 \
> +            lib:libz:gzip \
> +            lib:libiconv:libiconv \
> +            lib:libfontconfig:fontconfig \
> +            lib:libexpat.1:expat

You should prefer the port:-style dependency to the lib:lib:-style  
dependency unless there's a good reason. The good reason for XFree86  
is that many people will want to use Apple's X11 instead of XFree86.  
But there's no good reason for the rest of them. So this should read:

depends_lib lib:libX11.6:XFree86 \
	port:gzip \
	port:libiconv \
	port:fontconfig \
	port:expat

http://geeklair.net/new_macports_guide/#portfile- 
reference.dependencies.nonport

"Port dependencies should refer to other MacPorts ports whenever  
possible. However, if satisfying a dependency with a port is not  
practical or desirable for a special reason, you may specify  
dependencies by having MacPorts test for an individual file by  
replacing port: with one of the options lib: bin: or path:."

> +# Ticket #11901, Thanks to Christian Cornelssen (ccorn at cs.tu- 
> berlin.de).
> +# Make included JasPer find its own headers rather than the system  
> ones
> +configure.cppflags-delete   "-I${prefix}/include"
> +configure.cppflags-append   "-I${worksrcpath}/jasper/src/libjasper/ 
> include"
> +configure.cppflags-append   "-I${prefix}/include"
> +
>  configure.args --mandir='\${prefix}/share/man'
>
>  build.target