[28060] trunk/dports/archivers/sharutils/Portfile

[Ryan Schmidt]

On Aug 19, 2007, at 11:31, source_changes at macosforge.org wrote:

> Revision: 28060
>           http://trac.macosforge.org/projects/macports/changeset/28060
> Author:   nox at macports.org
> Date:     2007-08-19 09:31:54 -0700 (Sun, 19 Aug 2007)
>
> Log Message:
> -----------
> sharutils:
>  * Updated to 4.7.
>  * NLS support is now a variant.

Why, by the way? Do you believe most people will not want native  
language support? There's a lot of software with NLS, and I think  
most of it is on by default. Do you propose going through all of them  
to make NLS off by default? Why is this desirable? Why should we  
spend time on this? All it does, in the end, is give the user yet  
another choice they need to make. Our goal should not be to give the  
user every conceivable choice, but to use our expertise to choose a  
reasonable configuration for the user.

>  * libiconv has been added to the NLS dependencies.
>  * Fixed livecheck.
>  * Added doc installation.
>
> Modified Paths:
> --------------
>     trunk/dports/archivers/sharutils/Portfile
>
> Modified: trunk/dports/archivers/sharutils/Portfile
> ===================================================================
> --- trunk/dports/archivers/sharutils/Portfile	2007-08-19 16:31:39  
> UTC (rev 28059)
> +++ trunk/dports/archivers/sharutils/Portfile	2007-08-19 16:31:54  
> UTC (rev 28060)
> @@ -3,7 +3,7 @@
>  PortSystem			1.0
>
>  name				sharutils
> -version				4.6.3
> +version				4.7
>  categories			archivers
>  maintainers			nomaintainer
>  description			Shell archiver utilities
> @@ -17,20 +17,38 @@
>  					files, split long files and construct multi-part mailings,  
> ensure \
>  					correct unsharing order, and provide simplistic checksums.
>
> +homepage			http://www.gnu.org/software/${name}/
>  master_sites		gnu:${name}/REL-${version}
> -homepage			http://www.gnu.org/software/${name}/
>  use_bzip2			yes
>
> -checksums           md5 ec4c932d0704efe288d82219b089a3dc \
> -                    sha1 a036736307b814695ca68d04c465fdc4e5889218 \
> -                    rmd160 3beb2c202610d65d8df1e9ea585cfcb28dcb9897
> +checksums			md5 729c070d814d9c688489d88dd7fd3efb \
> +					sha1 0b8c1d54fdcf97a93aba079d342d1873a8fc423b \
> +					rmd160 6ef271d21ea41003ff13d6aef241c6a4fd4dc296
>
> -depends_lib			port:gettext
> -
>  configure.args-append	--mandir=${prefix}/share/man \
> -						--infodir=${prefix}/share/info
> +						--infodir=${prefix}/share/info \
> +						--disable-nls
>
> +set docdir				${prefix}/share/doc/${name}-${version}
> +
> +post-destroot {
> +	xinstall -d ${destroot}${docdir}
> +	xinstall -m 0644 -W ${worksrcpath} AUTHORS COPYING ChangeLog NEWS  
> README THANKS TODO \
> +		${destroot}${docdir}
> +}
> +
> +variant nls description {Enable NLS support} {

I think the name of the variant ("nls") makes it pretty clear that it  
"Enable[s] NLS"; the person who needs to read the description,  
however, is the one who doesn't know what "NLS" stands for. If this  
variant is retained, the description should be more helpful.

FYI, since "NLS" stands for native (or natural) language support,  
"NLS support" is just as redundant as "ATM machine" or "PIN number". :-)

> +	depends_lib-append		port:gettext \
> +							port:libiconv
> +
> +	configure.args-delete	--disable-nls
> +
> +	post-destroot {
> +		xinstall -m 0644 ${worksrcpath}/ABOUT-NLS ${destroot}${docdir}
> +	}
> +}
> +
>  livecheck.check		regex
> -livecheck.url		http://ftp.gnu.org/gnu/sharutils/REL-${version}/
> -livecheck.regex		${name}-(\\d+(?:\\.\\d+)*)
> +livecheck.url		http://ftp.gnu.org/gnu/sharutils/?M=D
> +livecheck.regex		REL-(\\d+(?:\\.\\d+)*)