[26328] trunk/dports/gnustep/Etoile/Portfile

[Juan Manuel Palacios]

	Hi Yves! A couple of notes about this commit, if you don't mind:

On Jun 19, 2007, at 5:17 PM, source_changes at macosforge.org wrote:

> Revision
> 26328
> Author
> yves at macports.org
> Date
> 2007-06-19 14:17:05 -0700 (Tue, 19 Jun 2007)
> Log Message
>
> Add a devel variant to keep the unstable stuff out of the stable  
> (Oh boy !)

	I couldn't make it out from your edits, so I'm not sure if the devel  
variant changes the port version number (a big NO-NO!!), but even if  
it doesn't everybody is much better off if you turn it (the devel  
variant) into a different port. Even if for consistency with other - 
devel ports.

	Also:

> Modified Paths
>
> trunk/dports/gnustep/Etoile/Portfile
> Diff
>
> Modified: trunk/dports/gnustep/Etoile/Portfile (26327 => 26328)
>
> --- trunk/dports/gnustep/Etoile/Portfile	2007-06-19 20:56:13 UTC  
> (rev 26327)
> +++ trunk/dports/gnustep/Etoile/Portfile	2007-06-19 21:17:05 UTC  
> (rev 26328)

---snip---

> +    system "
> +        cd GNUstep/Local/Tools &&
> +        ln -s ../Applications/Calc.app/Calc &&
> +        cd ../Library/Headers &&
> +        rm -f AddressBook &&
> +        ln -s Addresses AddressBook
> +    "
>  }

	You don't need a "system" call to do any of those things. Portfiles  
understand cd, we have an internal implementation for ln and one for  
delete

>
>
> +variant devel {
> +    build.args-delete       etoile-extensions=no menuserver=yes  
> jabber=no outerspace=no sketch=no
> +    destroot.args-delete    etoile-extensions=no menuserver=yes  
> jabber=no outerspace=no sketch=no
> +    build.args-append       debug=yes corner=no
> +    destroot.args-append    debug=yes corner=no
> +
> +    post-destroot {
> +        cd ${destroot}${prefix}
> +        xinstall -d GNUstep/System/Library/Etoile
> +        xinstall -m 644 ${worksrcpath}/Services/Private/System/ 
> SystemTaskList.plist \
> +            GNUstep/System/Library/Etoile
> +        xinstall -d share/xsessions
> +        xinstall -m 644 ${worksrcpath}/Services/Private/System/ 
> etoile.desktop \
> +            share/xsessions
> +        system "
> +            echo \". ${prefix}/GNUstep/System/Library/Makefiles/ 
> GNUstep.sh; \
> +            etoile_system\" > bin/etoile &&
> +            chmod 755 bin/etoile
> +

	Maybe you can use xinstall here to tweak those permissions...?


-jmpp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.macosforge.org/pipermail/macports-dev/attachments/20070619/61209737/attachment.html