[39128] trunk/dports/devel/darcs/Portfile

[Ryan Schmidt]

On Aug 9, 2008, at 09:21, gwright at macports.org wrote:

> Revision: 39128
>           http://trac.macosforge.org/projects/macports/changeset/39128
> Author:   gwright at macports.org
> Date:     2008-08-09 07:21:51 -0700 (Sat, 09 Aug 2008)
> Log Message:
> -----------
> Add a +nolibcurl variant and make it the default. (Works around
> a bug that causes darcs built with libcurl to hang sometimes.)
>
> Modified Paths:
> --------------
>     trunk/dports/devel/darcs/Portfile
>
> Modified: trunk/dports/devel/darcs/Portfile
> ===================================================================
> --- trunk/dports/devel/darcs/Portfile	2008-08-09 11:01:16 UTC (rev  
> 39127)
> +++ trunk/dports/devel/darcs/Portfile	2008-08-09 14:21:51 UTC (rev  
> 39128)
> @@ -4,7 +4,7 @@
>
>  name            darcs
>  version         2.0.2
> -revision	1
> +revision	2
>  categories      devel
>  maintainers     gwright at macports.org
>  description     David's Advanced Revision Control System
> @@ -31,6 +31,8 @@
>  configure.args  --mandir=${prefix}/share/man	\
>  		--without-docs
>
> +default_variants	+nolibcurl
> +
>  variant docs description {Generate a printable manual} {
>  		depends_build-append	port:latex2html
>
> @@ -43,3 +45,9 @@
>  		patchfiles-append	patch-GNUmakefile.diff
>  }
>
> +variant nolibcurl description {Build darcs without libcurl} {
> +		configure.args-append	--without-libcurl
> +		depends_lib-delete	port:curl
> +		depends_run-append	port:wget
> +}

With this change, if someone really wants curl support, they will  
find it difficult to get (and keep), because they will install this way:

sudo port install darcs -nolibcurl

(to deselect the nolibcurl variant), but when they later need to  
upgrade the port (to a newer version for example) MacPorts will again  
add the +nolibcurl variant (because MacPorts does not store  
deselected variants in its registry).

So you should instead make this a positive variant called "curl".

Also, since the choice you are offering is not what one would call a  
checkbox (curl or no curl) but rather two radio buttons (curl or  
wget), you should provide two variants as in the attached patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: darcs-curl-wget.diff
Type: application/octet-stream
Size: 966 bytes
Desc: not available
Url : http://lists.macosforge.org/pipermail/macports-dev/attachments/20080811/28674d79/attachment.obj