[42996] trunk/dports/x11/xinit

[Ryan Schmidt]

On Dec 2, 2008, at 22:59, jeremyhu at macports.org wrote:

> Revision: 42996
>           http://trac.macports.org/changeset/42996
> Author:   jeremyhu at macports.org
> Date:     2008-12-02 20:59:42 -0800 (Tue, 02 Dec 2008)
> Log Message:
> -----------
> xinit: Version bump to 1.1.0 plus latest git updates for better  
> Tiger support

[snip]

> +post-destroot {
> +	system "mv ${destroot}/Library/LaunchAgents/org.x.startx.plist $ 
> {destroot}/Library/LaunchAgents/org.macports.startx.plist"
> +	system "mv ${destroot}/Library/LaunchDaemons/ 
> org.x.privileged_startx.plist ${destroot}/Library/LaunchDaemons/ 
> org.macports.privileged_startx.plist"
> +
> +	system "mkdir ${destroot}/${prefix}/lib/X11/xinit/xinitrc.d"
> +	system "cp ${filespath}/xinitrc.d/*.sh ${destroot}/${prefix}/lib/ 
> X11/xinit/xinitrc.d"
> +	system "chmod 755 ${destroot}/${prefix}/lib/X11/xinit/xinitrc.d/ 
> *.sh"
> +}

FYI it's preferable to use built-in tcl commands rather than starting  
a new shell using "system" where possible. So here's how that would  
look:


post-destroot {
	move ${destroot}/Library/LaunchAgents/org.x.startx.plist ${destroot}/ 
Library/LaunchAgents/org.macports.startx.plist
	move ${destroot}/Library/LaunchDaemons/org.x.privileged_startx.plist  
${destroot}/Library/LaunchDaemons/org.macports.privileged_startx.plist

	xinstall -d ${destroot}${prefix}/lib/X11/xinit/xinitrc.d
	eval xinstall -m 755 [glob ${filespath}/xinitrc.d/*.sh] ${destroot}$ 
{prefix}/lib/X11/xinit/xinitrc.d
}


I think this is right, but I've just typed it in here and haven't  
tested it. Also note you shouldn't put a slash before ${prefix}; $ 
{prefix} begins with a slash already.