[43132] trunk/dports/x11/xorg-libAppleWM/Portfile

[Jeremy Huddleston]

On Dec 5, 2008, at 13:44, Ryan Schmidt wrote:

> On Dec 5, 2008, at 15:14, jeremyhu at macports.org wrote:
>
>> Revision: 43132
>>          http://trac.macports.org/changeset/43132
>> Author:   jeremyhu at macports.org
>> Date:     2008-12-05 13:14:01 -0800 (Fri, 05 Dec 2008)
>> Log Message:
>> -----------
>> libAppleWM: autoreconf to build universal
>>
>> Modified Paths:
>> --------------
>>    trunk/dports/x11/xorg-libAppleWM/Portfile
>>
>> Modified: trunk/dports/x11/xorg-libAppleWM/Portfile
>> ===================================================================
>> --- trunk/dports/x11/xorg-libAppleWM/Portfile	2008-12-05 21:12:35  
>> UTC (rev 43131)
>> +++ trunk/dports/x11/xorg-libAppleWM/Portfile	2008-12-05 21:14:01  
>> UTC (rev 43132)
>> @@ -4,6 +4,7 @@
>>
>> name            xorg-libAppleWM
>> version         1.0.0
>> +revision        1
>> categories      x11 devel
>> maintainers     jeremyhu
>> description     X.org libAppleWM
>> @@ -21,8 +22,18 @@
>> use_parallel_build      yes
>>
>> depends_build   port:pkgconfig \
>> +                port:libtool \
>>                 port:xorg-applewmproto \
>>                 port:xorg-xproto \
>>                 port:xorg-xextproto
>> depends_lib     port:xorg-libX11 \
>>                 port:xorg-libXext
>> +
>> +pre-configure {
>> +	system "cd ${worksrcpath} && autoreconf -fvi"
>> +}
>
> If you're going to run autoreconf, you need to declare a build  
> dependency on the port that provides autoreconf...
> That would be the autoconf port. Probably declaring a build  
> dependency on all three (autoconf, automake, libtool) is required.

That's what that port:libtool dependency is for.  libtool depends on  
automake which depends on autoconf.  I didn't realize I needed to  
explicitly require all three. I'll update that.

> There was quite a lot of confusion around this with the libxml2  
> port; see r38015, r38175, r39322, r39551.
>
> And what's "-fvi" and is it really necessary? We have a preferred  
> method in MacPorts for running autoreconf, which currently is:

force (assumes all files are too old and reinstalls them all)
verbose (better debugging output)
install (copies missing aux files to make autoconf not complain)

> use_autoconf        yes
> autoconf.cmd        autoreconf

Does this trigger the dependencies as well, or do I need to explicitly  
do that?  I just copied this behavior from another port.

> In MacPorts 1.7.0 you'll be able to just:
>
> use_autoreconf        yes

And I assume there is a corresponding autoreconf.cmd, so I could set '- 
fvi' if needed?