[43674] trunk/dports/audio/esound/Portfile
Ryan Schmidt
ryandesign at macports.org
Sat Dec 13 13:12:54 PST 2008
On Dec 13, 2008, at 10:53, mcalhoun at macports.org wrote:
> Revision: 43674
> http://trac.macports.org/changeset/43674
> Author: mcalhoun at macports.org
> Date: 2008-12-13 08:53:01 -0800 (Sat, 13 Dec 2008)
> Log Message:
> -----------
> esound: For OS X >= Leopard, prevent esound from trying to get the
> host name from the DISPLAY environment variable.
> Replace patchfiles with reinplace.
> Fixes #13848.
Just out of curiosity, why replace patchfiles with reinplace calls? I
find patchfiles to be nicer because they give context on what's being
changed (line numbers and a few lines before and after). If the
source changes in a future version and a patch no longer applies, you
can compare the source and the patch and usually get some idea of how
the patch needs to be changed to apply again. Plus until we commit
the patch in #15514 and release a new version of MacPorts, you won't
get any warning if a reinplace fails.
http://trac.macports.org/ticket/15514
If you really do want to use reinplace instead, then you should
remove the patchfiles too.
More information about the macports-dev
mailing list