[43674] trunk/dports/audio/esound/Portfile

Marcus Calhoun-Lopez mcalhoun at macports.org
Sat Dec 13 14:39:54 PST 2008


Ryan Schmidt <ryandesign at ...> writes:

> Just out of curiosity, why replace patchfiles with reinplace calls?
You make a good case for patchfiles, but, just as a personal preference,
I default to reinplace.
Usually, I find them easier to understand as I read, line by line,
through a Portfile.
Of course, in either case, a well constructed comment is very helpful.

I only use esound as a part of other ports, so
I am happy to change it back if there are strong objections.
 
> If you really do want to use reinplace instead, then you should  
> remove the patchfiles too.
I was going to keep them around for a few days in case my use of
reinplace caused problems.
Although I suppose a call to "svn copy" to resurrect a deleted file is
not too onerous a task.

-Marcus








More information about the macports-dev mailing list