[43674] trunk/dports/audio/esound/Portfile

[robert delius royar]

Sat, 13 Dec 2008 (15:12 -0600 UTC) Ryan Schmidt wrote:

>
> On Dec 13, 2008, at 10:53, mcalhoun at macports.org wrote:
>
>> Revision: 43674
>>           http://trac.macports.org/changeset/43674
>> Author:   mcalhoun at macports.org
>> Date:     2008-12-13 08:53:01 -0800 (Sat, 13 Dec 2008)
>> Log Message:
>> -----------
>> esound: For OS X >= Leopard, prevent esound from trying to get the host 
>> name from the DISPLAY environment variable.
>> Replace patchfiles with reinplace.
>> Fixes #13848.
>
> Just out of curiosity, why replace patchfiles with reinplace calls? I find 
> patchfiles to be nicer because they give context on what's being changed 
> (line numbers and a few lines before and after). If the source changes in a 
> future version and a patch no longer applies, you can compare the source and 
> the patch and usually get some idea of how the patch needs to be changed to 
> apply again. Plus until we commit the patch in #15514 and release a new 
> version of MacPorts, you won't get any warning if a reinplace fails.
>
> http://trac.macports.org/ticket/15514
>
> If you really do want to use reinplace instead, then you should remove the 
> patchfiles too.

I tried to reopen this ticket (#13848), but I do not have the 
permission.  I added a comment to it from another account (x11 at 
frinabulax dot org).  The reinplace patch does not fix the original 
problem.  It may be it fixes another problem. I grabbed the current 
sources after upgrading the macports installed port resulted in esdplay 
not being able to play sounds (nor was XEmacs able to play its alerts). 
I added back the "fix" I submitted in the original patch (ticket 13848), 
and both esdplay and XEmacs are making sounds again.  I do not believe 
that the logic that encloses the reinplace change (the flow logic in 
esdlib.c) is reached in all cases, and the case where the esd program 
would fail for me was one of those.

My original patch is not the correct way, that, I would leave to a 
programmer.  The two problems with my patch are that it will not be 
correct if other servers than :0 are running, and it does not check to 
see if the OS X version is one that uses launchd sockets.

-- 
Dr. Robert Delius Royar                   Associate Professor of English
Morehead State University                             Morehead, Kentucky