[32983] trunk/dports/gnome/libgtkhtml3/Portfile

[Juan Manuel Palacios]

On Jan 15, 2008, at 8:23 PM, nox at macports.org wrote:

> Revision
> 32983
> Author
> nox at macports.org
> Date
> 2008-01-15 16:53:06 -0800 (Tue, 15 Jan 2008)
> Log Message
>
> libgtkhtml3:
>  * Fixed dependencies.
>  * Removed useless configure env variable.
> Modified Paths
>
> trunk/dports/gnome/libgtkhtml3/Portfile
> Diff
>
> Modified: trunk/dports/gnome/libgtkhtml3/Portfile (32982 => 32983)
> --- trunk/dports/gnome/libgtkhtml3/Portfile	2008-01-15 23:56:28 UTC  
> (rev 32982)
> +++ trunk/dports/gnome/libgtkhtml3/Portfile	2008-01-16 00:53:06 UTC  
> (rev 32983)
> @@ -2,10 +2,11 @@
>
>  PortSystem  1.0
>
> -name		libgtkhtml3	
> +name		libgtkhtml3
>  set my_name gtkhtml
>  version		3.16.0
>  set branch  [join [lrange [split ${version} .] 0 1] .]
> +set revision 1
>


	Off the top of my head, I'd be wary this local "revision" variable  
may collide with the internal "revision" property of Portfiles. I  
don't see any other use of "revision" in your Portfile which makes me  
think that you are using it in the regular context of a Portfile  
revision; but if that's the case, why do you use "set"?

	Regards,...


-jmpp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.macosforge.org/pipermail/macports-dev/attachments/20080116/b5238415/attachment.html