[MacPorts] #15395: Use primary port category for fetched distfile layout

[William Siegrist]

Could I get a review of this patch from someone with some base  
experience to make sure this wont break anything. I believe it'll be  
seamless for end users and is the simplest change to make the mirror  
layout the way I want it to.

Thanks

-Bill


On May 21, 2008, at 10:46 PM, MacPorts wrote:

> #15395: Use primary port category for fetched distfile layout
> ------------------------------------ 
> +---------------------------------------
> Reporter:  wsiegrist at apple.com     |       Owner:  wsiegrist at apple.com
>     Type:  enhancement             |      Status:  new
> Priority:  Normal                  |   Milestone:
> Component:  base                    |     Version:
> Keywords:  fetch mirror distfiles  |
> ------------------------------------ 
> +---------------------------------------
> The distfile directory ($prefix/var/macports/distfiles/) currently  
> uses 1
> level of directory based on port name. This means mirroring also  
> uses the
> single directory level.
>
> I propose to use the primary category to layout mirrors and  
> distfiles with
> an additional directory. The main reason for this is the layout on
> distfiles.macports.org.  We need the 2 layers of directories to make
> browsing more managable.
>
> The change will be mostly invisible to users as far as their local
> installations are concerned.  This will make distfiles match the  
> layout of
> Portfiles in the svn and rsync repositories.
>
> The simplest fix, and the one I provide a patch for here, is to read  
> the
> categories value and set distpath accordingly during fetch_init. This
> affects all fetching and mirroring. The only impact I see to end  
> users is
> if they pre-fetch something, upgrade to the patched code, then try to
> install. The distfile would be in the wrong place and re-fetched. This
> case seems rare and a minor inconvenience at that.
>
> -- 
> Ticket URL: <http://trac.macports.org/ticket/15395>
> MacPorts <http://www.macports.org/>
> Ports system for Mac OS



-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2421 bytes
Desc: not available
Url : http://lists.macosforge.org/pipermail/macports-dev/attachments/20080521/3b1143d8/attachment-0001.p7s